Repository navigation
fix(ui): toasts match the app's style and show the right type for each message - #345
Merged
Merged
Conversation
Each toast has an icon strip and border in its type colour on a tinted panel, the same as the extensions info block. The soft shadow is now the solid darker base that raised buttons use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy toasts were a mix of info and success; they are all success now. "No update available", "already imported" and "re-sync already running" are info, not error or warn. An invalid zone tree file is an error, and a zone import that skips zones is a warning. The rule for each type is in notifications.ts. Also fixes "Command successful executed". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both stop what the user asked for, so they use the error type, not warn. An empty CSV or TSV file stops the import, like the wrong file type. An invalid email domain is not added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toasts were solid blocks of colour with a soft shadow. They did not look like the rest of the app. Some also used the wrong type: copy toasts were a mix of blue and green, and "No update available" was a red error.
Toasts now look like the info block on the extensions admin page. Each has an icon strip and border in its type colour on a tinted panel, and the same solid shadow as raised buttons. Light and dark themes both work.
Each toast now uses the type that matches what happened. The rule is above the helpers in
notifications.ts:Changes to the type:
Also fixes the text "Command successful executed".
Reviewed with sol-loop: 2 rounds with gpt-6.1-sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code