Repository navigation
Read embedded MusicBrainz IDs, rotate the Daily Mix, improve shuffle, add mix gestures - #236
Merged
Merged
Conversation
Library scans now store MUSICBRAINZ_TRACKID/ALBUMID/ARTISTID from ID3, MP4 and Vorbis/Opus tags, so ListenBrainz scrobbles carry the recording MBID without a manual lookup. Malformed IDs are dropped, and IDs from an earlier scan or manual lookup survive a rescan that reads no tags; previously every rescan wiped them. Fixes #223
The per-day noise in the ranking was 0.005, too small to reorder anything, so with little listening history the mix came out the same every day (the newest songs when nothing had been played). It now varies enough to rotate songs with similar scores while staying stable within a day. Fixes #222
Turning shuffle on now moves the playing song to the front, like other players, so no song is left behind it until the queue repeats; moving the playing item keeps playback going. When a shuffled repeat-all queue starts over, a new order is drawn instead of looping the same one. Fixes #205
- Long-pressing a Your Mix cover or a Daily Mix row on Home opens the song options, like the Recently Played pills. - Swiping a song row toward the end edge queues it in playlist, album, artist, genre, Daily Mix and Recently Played lists. Settings > Behavior > Song lists chooses add to queue (default), play next, or off. Library tabs keep it off since their pager swipes sideways, and it is off in selection, reorder and remove modes. - The Play label in the song options sheet shrinks to one line, so long translations such as Italian "Riproduci" are no longer cut. Fixes #213
[Medium impact] The PR appears safe to merge, with no new actionable issues established.
|
When Home shows the library preview in place of Your Mix, tapping a cover queues the full library, but Play in the long-press options queued only the 48-song preview. Both now build the full library queue.
Pausing fades the audio out over 500 ms, and the session kept reporting "playing" until the fade ended. That overwrote the pause the app had already shown, so the pause button changed about 0.7 s after the tap, and a second tap inside the fade paused again instead of resuming. FadingPlayer now reports paused from the first fade step and reports playing again when play cuts the fade short. The fade itself is unchanged. Fixes #238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223, #222, #205 and #213. There is one commit per issue, so they can be reviewed one at a time.
#223: read MusicBrainz IDs from embedded tags
MUSICBRAINZ_TRACKID,MUSICBRAINZ_ALBUMIDandMUSICBRAINZ_ARTISTID. TagLib maps them from ID3 (UFID/TXXX), MP4 freeform atoms and Vorbis/Opus comments; JAudioTagger is the fallback. The IDs go intomb_recording_id/mb_release_id/mb_artist_id.id1; id2), the first valid one is kept..m4atags are read only on a deep scan, as before.#222: Daily Mix never changes
The per-day noise in the ranking was
0.005, too small to reorder anything. With little listening history, the mix came out the same every day; with none at all, it was just the newest songs. The noise is now0.25. Songs with similar scores rotate between days, and the mix stays the same within a day.#205: shuffle
I followed what other open-source players do:
#213: gestures
Testing
:app:compileDebugKotlinpasses.0.005noise and passes with the new value.:app:testDebugUnitTesthas 6 failures and:app:lintDebugfails withMissingTranslation. All of these come fromvalues-pt-rBR(Add Brazilian Portuguese translation #232), which is already onmainand only partly translated. None of them involve strings from this PR.