Repository navigation
fix(queue): keep the "Next up" title on one line - #2973
Open
ismael-ares wants to merge 1 commit into
Open
ismael-ares wants to merge 1 commit into
ismael-ares wants to merge 1 commit into
Conversation
The queue header title used headlineLarge in a weighted column next to the source badge (up to 190dp). Longer translations such as Spanish "A continuación" did not fit and were broken mid-word across lines. Keep the title on a single line and let it shrink to fit (auto-size down to 20sp), cap it at 60% of the header width, and give the remaining space to the source badge, which already ellipsizes its label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Next up" title in the queue sheet is laid out in a weighted column next to the queue source badge (up to 190dp). Longer translations don't fit, and Compose breaks the word across lines: Spanish "A continuación" renders as "A / continuaci / ón", and German "Als nächstes" wraps to two lines and pushes the list down. It's most visible with a long queue source name (e.g. a shuffled playlist).
Changes (
QueueHeaderinQueueBottomSheet.kt)TextAutoSize.StepBased, down to 20sp) instead of wrapping.Before / after (Pixel 10 emulator, API 37)
Spanish, with a shuffled playlist as the queue source:
German:
All app locales and larger font scales (after)
Tested