Fix error with C99 style comments (//) should be (/**/)#138
Open
CollinMcKinney wants to merge 1 commit into
Open
Fix error with C99 style comments (//) should be (/**/)#138CollinMcKinney wants to merge 1 commit into
CollinMcKinney wants to merge 1 commit into
Conversation
Author
|
It builds fine under Clang with the // comments, but it's not part of ANSI C89. When trying to build under GCC I get a compile error. I'm unsure how MSVC handles this, but regardless it breaks ANSI C89 compliance even if some compilers allow it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// style comments aren't part of C89, they were added in C99
/* C89 only has this style of comment */