fix: align shell guidance with execution - #42
Open
zhuowp wants to merge 1 commit into
Open
Conversation
Signed-off-by: z27014 <zhuo.wenpei@h3c.com>
|
Thanks @zhuowp for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bash tool currently advertises a login shell even when the execution dispatcher selects Windows PowerShell. Models can consequently emit Unix pipelines such as
curl ... | head, despite the system environment label.Derive the tool and command descriptions from the same dispatcher, retain guidance for Bash/POSIX sh/zsh and custom shell paths, and preserve the existing execution and background-task contracts. This is the r13 backport; the reusable implementation is submitted separately in Hmbown#5900 against upstream main.
Validation: final CodeWhale library target compiled; 23 selected guidance tests passed, including catalog consistency and export. Across 40 real-model curl-reminder ablation calls on Windows PowerShell 5.1, each arm had 19/20 correct results and zero shell mismatch errors. The final wording omits the redundant tool-level curl reminder. Those simulations include application instructions and are not desktop end-to-end or non-Windows runtime coverage.
No dispatcher, permission, schema-field, or tool-name changes. Existing PowerShell invocation fix Hmbown#4593 is already in the base. Parent application integration will pin this commit; no release tag is moved.
Independent AI-assisted source review found no blocking findings for this r13 backport. All six current PR checks passed, including Windows shell regressions. Parent integration Pinvou/pinvou-agent#443 remains draft until an authorized maintainer publishes the actual new immutable Pinvou release; this PR being ready does not publish that release.