fix(shell): preserve task origin in job snapshots - #40
Open
zhuowp wants to merge 1 commit into
Open
Conversation
Signed-off-by: zhuowp <zwp-1989@qq.com>
|
Thanks @zhuowp for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No-Issue: backport of the independently tracked upstream fix for the Pinvou v0.9.5 maintenance branch.
Summary
Why
Background shell jobs outlive the tool call that created them. Without stable origin identity, an embedding host can attach a late failure from an earlier command to a newer tool card, especially when commands are identical or a wait call observes multiple jobs.
Scope
This is the Pinvou v0.9.5 fork backport of the reusable upstream fix proposed in Hmbown#5869. It deliberately does not add a revision counter or origin fields to generic tool-result metadata, because a wait result can summarize jobs from multiple origins.
Verification
cargo check -p codewhale-tui --lib --lockedcargo fmt --allgit diff --checkUpstream: Hmbown#5869