Skip to content

fix(search): update stale chain-tail copy and backend list - #39

Open
asto18089 wants to merge 1 commit into
Pinvou:pinvou3-cleanfrom
asto18089:fix/web-search-chain-tail-docs
Open

fix(search): update stale chain-tail copy and backend list#39
asto18089 wants to merge 1 commit into
Pinvou:pinvou3-cleanfrom
asto18089:fix/web-search-chain-tail-docs

Conversation

@asto18089

@asto18089 asto18089 commented Sep 2, 2026

Copy link
Copy Markdown

Context

No-Issue: the CodeWhale repo tracks no issues; this batch is tracked as Pinvou/pinvou-agent#377 (r12 review leftovers).

Leftovers from the r12 release review (Pinvou/pinvou-agent#375, tracked as Pinvou/pinvou-agent#377): after #35 moved the keyless fallback tail for API-backed [search] providers from DuckDuckGo straight to Bing, three foundation-side spots still describe the old DuckDuckGo hop or an incomplete backend list. Docs/diagnostics only — no behavior change.

Changes

  1. Model-visible web_search description (crates/tui/src/tools/web_search.rs:106): no longer claims "Configured API backends visibly degrade through DuckDuckGo then Bing"; now states the actual behavior — a visible degrade through the keyless Bing tail — matching the wording already used in crates/tui/src/config/search.rs.
  2. Module doc (web_search.rs:1-7): the chain is now described as provider-native search, configured API search, then a keyless Bing tail chosen by reachability; API outages never route through DuckDuckGo, while the configured DuckDuckGo route keeps its own one-way Bing scrape fallback.
  3. All-backends-down suggestion (crates/tui/src/tools/web/backend.rs:264): now lists all seven selectable API-backed providers (tavily, bocha, metaso, searxng, baidu, volcengine, sofya)searxng and sofya were missing, although tools/spec.rs and docs/CONFIGURATION.md both count them as API-backed.
  4. CHANGELOG: adds the missing \[Unreleased\] / Fixed entry for the fix(search): API 后端失败兜底从 DuckDuckGo 换成 Bing #35 chain-tail switch.

Not included

The optional DuckDuckGo image-search Bing fallback in web_run.rs (item 4 of the tracking issue) is a new scraping adapter with its own parsing surface and tests, not a copy/diagnostics cleanup; left out of this PR to keep the batch reviewable.

Verification

  • cargo test -p codewhale-tui --lib tools::web::backend — 10 passed, including forkguard_api_provider_chain_tail_is_bing and the all-backends-down error-message test.
  • cargo test -p codewhale-tui --lib tools::web_search — 66 passed.
  • cargo fmt -p codewhale-tui -- --check — clean.
  • Parent-repo ./scripts/fork-guard.sh --fast — all fingerprint layers pass; the only two failures are the layer-0 gitlink topology check, which resolves when the next baseline batch registers this commit (the tracking issue defers the parent gitlink to the next baseline batch).

Signed-off-by: asto18089 asto18089@126.com

The r12 chain-tail switch (Hmbown#35) moved the keyless fallback for API-backed
[search] providers from DuckDuckGo straight to Bing, but the web_search
module doc and the model-visible description still claimed a DuckDuckGo
hop, and the all-backends-down suggestion listed only five of the seven
selectable API-backed providers (missing searxng and sofya). Align the
copy with the actual chain, complete the suggestion list, and add the
missing CHANGELOG entry for the switch.

Signed-off-by: asto18089 <asto18089@126.com>
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Thanks @asto18089 for taking the time to contribute.

This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered.

Please read CONTRIBUTING.md for the expected contribution shape. A maintainer can grant recurring PR access by commenting /lgtm on a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant