Add more control over multiscale clean scales#362
Open
thomaswilliamsastro wants to merge 1 commit into
Open
Conversation
thomaswilliamsastro
force-pushed
the
multiscale-beam-scales
branch
from
4dd5c07 to
b8d66f1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
=========================================
+ Coverage 6.28% 6.30% +0.02%
=========================================
Files 38 38
Lines 15209 15297 +88
Branches 3654 3674 +20
=========================================
+ Hits 956 965 +9
- Misses 14239 14318 +79
Partials 14 14 ☔ View full report in Codecov by Harness. |
thomaswilliamsastro
force-pushed
the
multiscale-beam-scales
branch
2 times, most recently
from
59ed5a6 to
ebf201b
Compare
Collaborator
Author
|
Moving this back to draft following useful feedback at ADR today |
thomaswilliamsastro
force-pushed
the
multiscale-beam-scales
branch
from
ebf201b to
8c816a4
Compare
Collaborator
Author
|
Beam is now pulled from image if available, exposed the important controls for the automatic clean scale setting, and docs updated @low-sky ready for review! |
thomaswilliamsastro
force-pushed
the
multiscale-beam-scales
branch
from
8c816a4 to
4f92a8b
Compare
This PR adds two new options for setting multiscale clean scales, ``clean_scales_beam`` and ``clean_scales_auto``. The list ``clean_scales_beam`` option allows you to define clean scales as multiples of the beam. If both ``clean_scales_beam`` and ``clean_scales_arcsec`` are defined, then these will be both be used to form a single list of clean scales. The boolean ``clean_scales_auto`` option, allows for fully automatic setting of the clean scales based on the beam and the LAS of the data. If this is set to True, then will add scales of [0, beam FWHM], then continue multiplying by ``clean_scales_auto_factor`` (default 2) up to ``clean_scales_max_las_fraction`` * the LAS of the data (default 1). Note that setting this will override ``clean_scales_arcsec`` and ``clean_scales_beam``. - Add ``clean_scales_beam`` - Add ``clean_scales_auto`` - If available, pull beam size from image, or fall back to calculating from visibilities - Clean scales are now rounded, rather than simply cast to int - Update docs - Update CHANGELOG
thomaswilliamsastro
force-pushed
the
multiscale-beam-scales
branch
from
4f92a8b to
ed287da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270
This PR adds two new options for setting multiscale clean scales,
clean_scales_beamandclean_scales_auto.The list
clean_scales_beamoption allows you to define clean scales as multiples of the beam. If bothclean_scales_beamandclean_scales_arcsecare defined, then these will be both be used to form a single list of clean scales.The boolean
clean_scales_autooption, allows for fully automatic setting of the clean scales based on the beam and the LAS of the data. If this is set to True, then will add scales of [0, beam FWHM], then continue multiplying byclean_scales_auto_factor(default 2) up toclean_scales_max_las_fraction* the LAS of the data (default 1). Note that setting this will overrideclean_scales_arcsecandclean_scales_beam.clean_scales_beamclean_scales_auto