-
-
Notifications
You must be signed in to change notification settings - Fork 159
fix(next): pass production App Route dylib gate #8082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12,547
−2,271
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3015681
fix(next): pass production app route dylib gate
91a4137
fix: address production app route review
9d228b2
fix(runtime): root bound method construction
5938676
fix(codegen): keep native statepoint roots in app dylibs
17753a0
fix(codegen): optnone post-RS4GC relocation-bloated functions
e248189
chore: split oversized files back under the 2000-line lint cap
13cace8
fix(codegen): reserve deep stacks for LLVM unit workers
a1c91d4
fix(codegen): exempt the inline-asm loop barrier from RS4GC
c133250
fix(runtime): claim action-zero landing pads as Perry catches again
b81c792
docs: expand the changeset with the statepoint compile and EH fixes
58ec938
fix(runtime): root the generic array-like callback loops across their…
6715fe8
fix(runtime): root call/apply and put-value locals across their JS in…
b6d9106
fix(ffi): transient GC roots for ext-crate callback snapshots
a587aef
feat(gc): sharpen the from-space scan and stack-map walk instruments
7c1f6d7
chore: classify the bound-method test hook in the root-holder registry
1e9731d
docs: extend the changeset with the rooting sweep and instruments
ee97c7d
feat(gc): name the HOLDERS of a stale from-space address, not just th…
3a7ad78
merge origin/main into the App Route fixture branch
a5415a5
fix(next): declare panic=abort in the provider workspace
38e1c44
merge origin/main into the production App Route branch
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| ### Fixed | ||
|
|
||
| - Preserve production Next.js App Route request state through generated | ||
| `AppRouteRouteModule.handle` dispatch, imported handlers, async | ||
| continuations, and separately loaded runtime/stdlib providers (#8036). | ||
|
|
||
| - Keep native statepoint roots in an app dylib. The demotion of | ||
| `--output-type dylib` artifacts to the shared shadow stack predated | ||
| #8081's loaded-image stack-map indexing; with that in place it would | ||
| leave provider apps running a lowering production never ships, and it | ||
| defeated #8081's own gate assertion that the app's map survives macOS | ||
| dead stripping. | ||
|
|
||
| - Class-self lowering respects a same-named method parameter or local | ||
| instead of forcing the lexical class binding; computed `require(".")` / | ||
| `require("..")` resolve relative to the caller; dynamic virtual dispatch | ||
| builds its direct-call ABI from the selected override's own metadata, | ||
| including rest and synthetic `arguments` shape in both override | ||
| directions; bound-method construction roots the receiver across closure | ||
| allocation and the closure across allocating metadata installation; | ||
| malformed unwind-table records are parsed transactionally with checked | ||
| ranges and offsets. | ||
|
|
||
| ### Added | ||
|
|
||
| - A pinned Next 16.3.0 production App Route fixture | ||
| (`tests/release/packages/next-app-route/`): the untouched webpack output | ||
| is compiled as an app-only dylib against separate runtime and stdlib | ||
| provider images, then served through a `dlopen` host and compared with | ||
| the Node production oracle over 10 cold starts, each running two | ||
| 21-request verifier passes. | ||
|
|
||
| A forced-evacuation arm is available behind | ||
| `PERRY_NEXT_ROUTE_FORCED_GC=1` and is **not** part of the default gate: | ||
| it currently fails (#8163). When enabled, alternate cold starts run under | ||
| forced evacuation with GC diagnostics and their moving-GC liveness is | ||
| asserted by `scripts/gc_evacuation_liveness_assert.py`, so zero copying | ||
| minors or zero copied objects is a hard failure rather than a vacuous | ||
| pass. It is deliberately neither a `SKIP` (which would read as covered) | ||
| nor `continue-on-error` (which would make it documentation rather than a | ||
| gate): off by default, failing loudly when set. | ||
|
|
||
| - `PERRY_GC_PROTECT_FROMSPACE_HOLDERS=1`: at a from-space fault, sweep the | ||
| whole live heap for any word that still decodes to the faulting address | ||
| and name the owners. The existing report answers "who used it" — the | ||
| consumer, which for a value read out of a table one instruction earlier | ||
| is never the bug; this answers "who kept it". | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Hyphenate the compound modifiers.
Use
zero-copying minor collectionsandzero-copied objects. This prevents the liveness condition from being misread.🧰 Tools
🪛 LanguageTool
[grammar] ~37-~37: Use a hyphen to join words.
Context: ..._evacuation_liveness_assert.py`, so zero copying minors or zero copied objects ...
(QB_NEW_EN_HYPHEN)
[grammar] ~38-~38: Use a hyphen to join words.
Context: ...rt.py`, so zero copying minors or zero copied objects is a hard failure rather ...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Source: Linters/SAST tools