-
-
Notifications
You must be signed in to change notification settings - Fork 159
fix(android): unbreak perry-ui-android build and wire Picker onChange #8080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
proggeramlug
merged 3 commits into
PerryTS:main
from
keufcp:fix/android-picker-callback-and-json-extract-pointer
Aug 14, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
changelog.d/8080-android-picker-callback-and-json-extract-pointer.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| Fixed two Android defects that made `perry-ui-android` unbuildable and stopped | ||
| `Picker` from reporting selection changes. | ||
|
|
||
| `crates/perry-ui-android/src/json.rs` still called the `is_raw_pointer` helper | ||
| that #7448 deleted, so the crate failed to compile for any Android target | ||
| (`error[E0425]: cannot find function is_raw_pointer`). #7448 converted the | ||
| object path to `extract_pointer` but not the array-element path. Routing it | ||
| through the same helper also extends the #7447 fix to array elements: the old | ||
| bit test is the IEEE-754 positive-subnormal predicate, so every positive | ||
| denormal element in a stringified array was classified as a pointer and | ||
| dereferenced. | ||
|
|
||
| `PerryBridge.setSpinnerCallback` did not exist. `widgets/picker.rs` has always | ||
| called it over JNI and discarded the resulting error with `let _ =`, so | ||
| `Picker`'s `onChange` could never fire on Android — the widget rendered and | ||
| selected, and the app was simply never told. | ||
|
|
||
| Neither showed up in CI because the Android jobs in `feature-matrix.yml` are | ||
| `continue-on-error: true` and push-only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.