Skip to content

docs: perry-runtime's tests must run single-threaded locally, as CI already does #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 2 commits into from
Aug 10, 2026
Merged

docs: perry-runtime's tests must run single-threaded locally, as CI already does #7791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2310611
docs: perry-runtime's tests must run single-threaded locally, as CI a…
Aug 10, 2026
2365dfc
chore: bump version to 0.5.1461
Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co

Perry is a native TypeScript compiler written in Rust that compiles TypeScript source code directly to native executables. It uses SWC for TypeScript parsing and LLVM for code generation.

**Current Version:** 0.5.1460
**Current Version:** 0.5.1461


## TypeScript Parity Status
Expand Down Expand Up @@ -82,7 +82,8 @@ cargo build --release # Build all crates
cargo build --profile perry-dev -p perry # Fast local dev build (#5422; perry-dev profile)
cargo build --release -p perry-runtime -p perry-stdlib # Rebuild runtime (MUST rebuild stdlib too!)
cargo build --release -p perry-runtime-static -p perry-stdlib-static # Emit libperry_{runtime,stdlib}.a (#5422: runtime/stdlib are now rlib-only; the .a comes from these wrapper crates)
cargo test --release --workspace \
RUST_TEST_THREADS=1 cargo test --release -p perry-runtime # MUST be single-threaded (see below)
cargo test --release --workspace --exclude perry-runtime \
Comment on lines +85 to +86

@coderabbitai coderabbitai Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== CLAUDE.md line count and relevant lines =="
wc -l CLAUDE.md
sed -n '75,90p' CLAUDE.md
sed -n '235,245p' CLAUDE.md

echo
echo "== Check for current guideline in repository/config files =="
rg -n "supplied coding guideline|CLAUDE.md|Current Version|changes only|allowed documentation" -S .

Repository: PerryTS/perry

Length of output: 50372

Move CLAUDE.md guidance out of the change.

Coding guidelines allow CLAUDE.md to update only **Current Version:**. Lines 85-86 and 241 add test commands and runtime guidance instead, so get an approved exception or move this content to an allowed documentation file.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CLAUDE.md` around lines 85 - 86, Remove the added test commands and runtime
guidance from CLAUDE.md, including the content around the shown cargo test
commands and the related section near line 241. Keep CLAUDE.md limited to the
permitted Current Version update, or move the guidance to an approved
documentation file if it must be retained.

Source: Coding guidelines

--exclude perry-ui-ios --exclude perry-ui-tvos --exclude perry-ui-watchos \
--exclude perry-ui-visionos --exclude perry-ui-android --exclude perry-ui-windows \
--exclude perry-ui-gtk4 # Run tests (exclude cross-host UI crates on macOS)
Expand Down Expand Up @@ -236,6 +237,7 @@ Build outputs are invisible to `git status`, so a clean tree tells you nothing a
- **addr-class ratchet** (`scripts/addr_class_inventory.py`) — a file gaining a bare-address site fails `lint`.
- **`conformance-smoke` shards are flaky.** Before believing a red shard, re-run it and A/B the named tests against a pristine `main` build; several are already in `test-parity/known_failures.json`.
- **Integration suites under `crates/*/tests/*.rs` do not run per-PR** (nightly/tag only) — a regression there can land green and sit red for days. Prefer putting acceptance coverage in `cargo-test`-visible unit tests (#5960).
- **`perry-runtime`'s tests are not parallel-safe — run them `RUST_TEST_THREADS=1`.** They share process-global side tables (#1444), and ~180 readers are not required to take the clearing lock (see `gc::tests::global_sink_isolation`'s header; #7672 is converting them to `per_test_global!` one at a time). Every CI path already pins `RUST_TEST_THREADS=1`; a local `cargo test --workspace` does NOT, which is the whole gap. Measured on the default pool: 600 full-suite runs at `--test-threads=16` (load ~90) were clean, but at `--test-threads=64` (load ~115) **2 of 320 runs failed** — in `proxy::…numeric_write_guard…` and `array::element_shape::matrix_tests::matrix_delete_revokes`, neither related to the change under test. The tell is the message: these fail on their own *fixture precondition* ("fixture must start proven, or every verdict below is vacuous"), i.e. another thread wiped the global, not a real defect in the code under test. Chasing such a failure as if it were a regression is wasted days.

### ★ Four ways a gate can be unable to fail

Expand Down
Loading
Loading