fix(path): expose _makeLong alias#2793
Merged
proggeramlug merged 9 commits intoMay 30, 2026
Merged
Conversation
0568e26 to
07ecba0
Compare
# Conflicts: # crates/perry-runtime/src/object/native_module.rs # docs/api/perry.d.ts # docs/src/api/reference.md
6d8c9a3 to
ba5d7e6
Compare
# Conflicts: # docs/api/perry.d.ts # docs/src/api/reference.md
# Conflicts: # crates/perry-api-manifest/src/lib.rs # crates/perry-runtime/src/object/native_module.rs # docs/api/perry.d.ts # docs/src/api/reference.md
# Conflicts: # crates/perry-api-manifest/src/lib.rs # docs/api/perry.d.ts # docs/src/api/reference.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2683.
Summary
node:path_makeLongto the API manifest and generated docs._makeLongthrough the same lowering, runtime binding, and dispatch path astoNamespacedPathforpath,path.posix, andpath.win32.Repro
On
origin/main(94bbda1a), the new fixture exposed the missing alias as runtime-visibleundefinedvalues:Node 24 oracle output:
Fixed Perry output now matches the Node oracle.
Verification
PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH node --experimental-strip-types test-parity/node-suite/path/toNamespacedPath/make-long-alias.tsRUSTC_WRAPPER= target/release/perry test-parity/node-suite/path/toNamespacedPath/make-long-alias.ts -o /tmp/perry_path_makelong_2683 && /tmp/perry_path_makelong_2683PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH RUSTC_WRAPPER= ./run_parity_tests.sh --suite node-suite --module path --filter make-long-aliasPATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH RUSTC_WRAPPER= ./run_parity_tests.sh --suite node-suite --module path --filter toNamespacedPathcargo fmt --all -- --checkgit diff --check origin/main...HEAD./scripts/check_file_size.shjq empty test-parity/known_failures.json test-parity/threshold.jsonRUSTC_WRAPPER= cargo check -p perry-api-manifest -p perry-hir -p perry-runtimeRUSTC_WRAPPER= cargo test -p perry-api-manifestRUSTC_WRAPPER= cargo test -p perry-codegen --test manifest_consistency