Skip to content

fix(node:buffer): estimate base64 byte length #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
May 28, 2026
Merged

fix(node:buffer): estimate base64 byte length #2276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions crates/perry-runtime/src/buffer/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,19 @@ pub extern "C" fn js_buffer_byte_length_value(value: f64, encoding: f64) -> i32
return (len / 2) as i32;
}
if eq_ascii_lower(enc_bytes, b"base64") || eq_ascii_lower(enc_bytes, b"base64url") {
let decoded = base64_decode_into_buffer(bytes);
return (*decoded).length as i32;
// Node's Buffer.byteLength assumes valid base64/base64url input
// instead of decoding. It only discounts up to two trailing `=`
// padding characters, then applies the 3/4 base64 ratio.
let mut code_units = std::str::from_utf8(bytes)
.map(|s| s.encode_utf16().count())
.unwrap_or(len);
if code_units > 0 && bytes.last() == Some(&b'=') {
code_units -= 1;
if code_units > 1 && bytes.get(bytes.len().saturating_sub(2)) == Some(&b'=') {
code_units -= 1;
}
}
return ((code_units * 3) / 4) as i32;
}
if eq_ascii_lower(enc_bytes, b"ascii")
|| eq_ascii_lower(enc_bytes, b"latin1")
Expand Down