Skip to content

fix(node:zlib): expose stream instance shape#2265

Merged
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-zlib-stream-instance-shape
May 28, 2026
Merged

fix(node:zlib): expose stream instance shape#2265
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-zlib-stream-instance-shape

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

  • expose zlib stream params and reset as function-valued instance properties
  • track bytesWritten as a numeric property and publish it when queued zlib events drain
  • add a granular parity fixture for method shape, bytesWritten timing, and absent bytesRead

Part of #793.

Evidence

  • Baseline exact node-suite/zlib/streams/instance-methods-and-bytes: FAIL, report test-parity/reports/parity_report_20260528_100257.json
  • Final exact node-suite/zlib/streams/instance-methods-and-bytes: PASS, report test-parity/reports/parity_report_20260528_101327.json
  • Full granular node-suite/zlib: PASS 47/47, report test-parity/reports/parity_report_20260528_101344.json
  • cargo check -p perry-runtime -p perry-stdlib -p perry-codegen: PASS with existing warnings
  • cargo fmt --check: PASS
  • jq empty test-parity/known_failures.json: PASS
  • git diff --check: PASS

DeepWiki

  • reference/deepwiki/nodejs-node-zlib-stream-instance-shape-2026-05-28.md

Non-goals

@proggeramlug proggeramlug merged commit 4c53572 into PerryTS:main May 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants