fix(buffer): preserve stream consumer byte iteration#2254
Open
andrewtdiz wants to merge 2 commits into
Open
Conversation
50cea6e to
9cb8bd7
Compare
9cb8bd7 to
234f305
Compare
# Conflicts: # crates/perry-runtime/src/array/flat_clone.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node:stream/consumers.buffer().Symbol.iteratorlookups tovalues()while still respecting own symbol properties.Array.from(buffer)before probing GC metadata.buffer-byte-exactknown failure.Tests
cargo fmt --all -- --checkjq empty test-parity/known_failures.jsongit diff --check origin/main...HEAD./scripts/check_file_size.sh./run_parity_tests.sh --suite node-suite --module stream/consumers(33 pass, 0 fail)RUST_TEST_THREADS=1 cargo test -p perry-runtime(738 pass)CARGO_BUILD_JOBS=1 cargo test --workspace --exclude perry-runtime --exclude perry-ui-macos --exclude perry-ui-ios --exclude perry-ui-visionos --exclude perry-ui-tvos --exclude perry-ui-watchos --exclude perry-ui-gtk4 --exclude perry-ui-android --exclude perry-ui-windowsNon-goals