Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,38 @@ Utilization of Essentials Framework falls into the following categories:

For detailed documentation, see the [Wiki](https://github.com/PepperDash/EssentialsFramework/wiki).

## Room Combiner Operation Lifecycle

Essentials room combiner now exposes an operation lifecycle that clients can use to show progress and terminal status during scenario changes.

Lifecycle states:
- Idle
- InProgress
- Completed
- Failed
- TimedOut

The lifecycle is exposed on room combiners that implement the operation-status extension and is included in app server combiner messages under the combinationOperation payload.

Configuration:
- combinationOperationTimeoutSeconds (optional): timeout in seconds for an in-progress operation.
- Default when omitted: 300 seconds.
- Values less than or equal to 0 are treated as invalid and fall back to the default.

Example room combiner properties:

```json
{
"defaultToManualMode": false,
"defaultScenarioKey": "divided",
"combinationOperationTimeoutSeconds": 30,
"roomKeys": ["roomA", "roomB"]
}
```

Operational note:
- When an operation reaches a terminal state (Completed, Failed, TimedOut), the operation timeout timer is stopped.

## Support

* Check out our [Discord Server](https://discord.gg/rWyeRH3K)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using System;

using PepperDash.Core;
namespace PepperDash.Essentials.Core.DeviceTypeInterfaces
{
/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public bool PartitionPresent
{
if (IsInAutoMode)
{
return _partitionSensor.PartitionPresentFeedback.BoolValue;
return _partitionSensor?.PartitionPresentFeedback?.BoolValue ?? _partitionPresent;
}

return _partitionPresent;
Expand Down
Loading