refactor: add write_job_sh helper to PEcAn.utils to reduce duplicated job.sh logic#3921
Open
KrupaShah20 wants to merge 18 commits intoPecanProject:developfrom
Open
refactor: add write_job_sh helper to PEcAn.utils to reduce duplicated job.sh logic#3921KrupaShah20 wants to merge 18 commits intoPecanProject:developfrom
KrupaShah20 wants to merge 18 commits intoPecanProject:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3887
This PR adds a shared helper function
write_job_sh()toPEcAn.utilsand refactors all 17 model couplers to use it instead of duplicated
job.shwriting logic.Problem
Every
write.config.*function duplicated these same lines:writeLines(jobsh, con = file.path(...))Sys.chmod(file.path(...))This pattern was repeated across 17 different model packages making
the codebase harder to maintain and extend.
Solution
base/utils/R/write_job_sh.Rwith a fully documented helper functionPEcAn.utils::write_job_sh()base/utils/tests/testthat/test.write_job_sh.RModels Refactored
template, sipnet, rothc, sibcasa, ed, ed2-restart, fates, gday,
jules, ldndc, linkages, lpjguess, maat, maespa, peprmt, preles, stics
Testing
Added unit tests covering: