Repository navigation
Restore native Mono autocomplete sizing, focus and selection (#293) - #299
Draft
PawelTroka wants to merge 20 commits into
Draft
PawelTroka wants to merge 20 commits into
PawelTroka wants to merge 20 commits into
Conversation
…improve diagnostics
Owner
Author
Mono/X11 runtime investigation (26 October 2026)The first exact-head smoke implementation compiled, and 43 pre-existing Mono cases passed, but the new real-X11 autocomplete acceptance was initially failing. The failure is not just a test threshold: native X11 diagnostics found the hosted completion list outside the actual popup geometry. Example recorded by
The proposed fix sets Mono's Latest exact-head Mono test: workflow run 40325020999; queued as of this note. Do not treat the fix as validated until real X11 mouse insertion, scrolling, placement, and screenshot checks pass. Keep this PR draft and do not merge without explicit owner approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Refs #293. Linux/Mono autocomplete starts with an effectively screen-wide (up to 2,000 px) menu, does not bound the reference popup relative to actual remaining display space, and can show reference help before its completion list is placed. In the original WinForms popup, a click can also cause a focus-loss close before the Mono list receives the selecting event.
This deliberately retains the current WinForms
ToolStripDropDown/AutocompleteListView/MonoReferenceTextarchitecture. The new layout/focus/selection behavior is compiled under__MonoCS__, leaving the working Windows HTML reference and completion policy intact.Changes
GUI acceptance and screenshot evidence
Extended the existing
Mono-Validatesmoke suite with real X11 events via xdotool on Mono/WinForms (not simulated method calls). Cases cover:artifacts/mono/Release/autocomplete-after.png(uploaded by the Mono CI workflow).Before: original issue #293 screenshot (948 × 536, user-supplied).
After: actual painted popup screenshot (Ubuntu 24.04, exact-head
2394ffc); compared with the preceding run that showed mapped-but-unpainted windows.Review / validation status
2394ffcd953acceac68dac69d6678149397456af; screen captures inspected, including visible completion and help pixels.This is intentionally draft. Do not merge without the repository owner's explicit approval.
October 27 validation follow-up (in progress)
Current head:
2394ffcd953acceac68dac69d6678149397456af(commit).Computator.NET.slnxnow links the trackedbuild/mono/SmokeTests/MonoAutocompleteTests.cssource (a21a54f); original Windows, solution, reference, web and packaging failures had the same developer-solution inventory error.a21a54fed286c1129fb6410cdb69a6ae3178ad26passed native Mono CI with 44/44 smoke cases and developer solution CI. Native Mono XML and X11 screenshots were inspected.CaptureAutocompleteX11now requires genuine light popup-content pixels within the menu and reference rectangles, tries native repaint/pumping for up to five seconds, and saves the failure image if the controls are still unpainted. It does not synthesize screenshots or weaken visibility assertions (2394ffc).autocomplete-after.pngwith real painted suggestions and reference help, and the XML confirms the new pixel-visibility assertion passed. The Windows Cake run subsequently completed all four jobs successfully. Exact-head GSL source and GSL packaged workflows passed too. All 21/21 exact-head GitHub Actions workflows completed successfully, including release identity and candidate evidence. No failures or skipped workflows were reported for2394ffcd953acceac68dac69d6678149397456af.xdotool x11-utils(here) andlibxtst6(feat(mono): native interactive f(x,y) 3D surfaces in Linux WinForms #296/fix(mono): ensure active complex chart paints above overlapping native charts (#295) #298), reconcile Monovalidate.shevidence cleanup and preserve distinct smoke-test entry points; combined-branch CI has not yet been executed.Physical Linux desktop/compositor and DPI matrix acceptance remains unverified. Draft; no merge without approval.