Improve UI layout, item management, and socket editing - #10360
Open
AdamZ-8113 wants to merge 2 commits into
Open
AdamZ-8113 wants to merge 2 commits into
AdamZ-8113 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This PR adds dozens of minor UI/UX enhancements without meaningfully disrupting any of the UIs. Here's the detailed list of changes.
Tree
Skills
Optimise(sockets) button action into undo/redo history.Labelfield now dynamically updates based on the inferred label or user input<No active skills>, we show the name of the disabled skill gem in grey text first, with "no active skills" as a fallback.Imbued Supportas(Legacy), makes it grey, moves it below the gem selector, and stops it from highlighting other supports on hover.Count:now appears even if the first gem in a group is not a skill gem (Bug Fix).Items
Used byprefix before every loadout name, and now multiple loadouts are listed instead of only the first.Weapon 1, we no longer displayAmuletin thetypedrop down, and the type resets if the slot filter is changed.Wcharacter doesn't clip, and the link selectors use an=style design, instead of checkboxes. This more closely emulates how we display sockets on items.(Legacy)to the labels for Labyrinth enchants on Belts/Gloves/Boots.Add Crucible Modifier...into the Add Modifier button with a(Legacy)tag.Trade for these itemstoItem Finder (Weighted Mod Search)....Buy Similar...button is a much better representation of "Trade for these items".Calcs
Configuration
Import/Export
All (Overwrite)to both import routes to import the tree, jewels, equipment, and skills together in fewer clicks.Export Supportto fit better and renames itInclude Support DataMain UI / View
Newbutton.Save Asso that years of muscle memory aren't disruptedMovement Speed Modifier.Main Skill:drop downs, especially for things like minion or channeling skills.This PR should supersede #10292 (items page width)
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before & After Screenshots
This is a non comprehensive set, but showcases the overall intent