Skip to content

Allow changing the base of crafted items - #10358

Open
AdamZ-8113 wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
AdamZ-8113:feature/change-crafted-item-base
Open

AdamZ-8113 wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
AdamZ-8113:feature/change-crafted-item-base

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Fixes #10260

Description of the problem being solved:

Crafted items can't currently change their base without recreating the item and manually rebuilding its modifiers.

This adds a "Change Item Base" popup that shows the available types, bases, and implicits. Compatible modifiers, sockets, rolls, and item identity are preserved. The popup reports modifiers or influences that aren't compatible with the selected base before applying the change, and handles bases with special prefix, suffix, or influence rules (i.e. Simplex, Astrolabe Amulet, etc.)

Note: We favor keeping Eater/Exarch implicits over base item implicits, but this revealed a bug/behavioral issue in PoB where you can have an item like Two-Toned Boots with Eater/Exarch influence, apply those implicits to the boots, and the base implicit is retained, making it a 3-implicit item. I'll open a separate issue for this.

A few UX notes: The search box is highlighted when the modal opens, item diff tooltip appears on hover without clicking so that search doesn't lose focus, scroll without focus works, and the modal is sized to accommodate the majority of modifiers without being so large that it forces the item diff tooltip to jump around. Changing base types re-triggers the search against bases for the new type. The modal grows down only as descriptions are added, to keep it well positioned.

This modal could easily be adapted to replace the "Craft Item" workflow as well, if desired.

Steps taken to verify a working solution:

  • Full test suite
  • Lots of manual testing with many different items and permutations of modifiers

Link to a build that showcases this PR:

https://pob.codes/b/1AN2oaXLaWC

  • Use Rare Item DB panel to find many more items to change around

Before screenshot:

After screenshot:

image image image image

@AdamZ-8113

Copy link
Copy Markdown
Contributor Author

Removed the Other: field unless it has a meaningful message to display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing an item base mid-customization

1 participant