Allow changing the base of crafted items - #10358
Open
AdamZ-8113 wants to merge 2 commits into
Open
AdamZ-8113 wants to merge 2 commits into
AdamZ-8113 wants to merge 2 commits into
Conversation
Contributor
Author
|
Removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10260
Description of the problem being solved:
Crafted items can't currently change their base without recreating the item and manually rebuilding its modifiers.
This adds a "Change Item Base" popup that shows the available types, bases, and implicits. Compatible modifiers, sockets, rolls, and item identity are preserved. The popup reports modifiers or influences that aren't compatible with the selected base before applying the change, and handles bases with special prefix, suffix, or influence rules (i.e. Simplex, Astrolabe Amulet, etc.)
Note: We favor keeping Eater/Exarch implicits over base item implicits, but this revealed a bug/behavioral issue in PoB where you can have an item like Two-Toned Boots with Eater/Exarch influence, apply those implicits to the boots, and the base implicit is retained, making it a 3-implicit item. I'll open a separate issue for this.
A few UX notes: The search box is highlighted when the modal opens, item diff tooltip appears on hover without clicking so that search doesn't lose focus, scroll without focus works, and the modal is sized to accommodate the majority of modifiers without being so large that it forces the item diff tooltip to jump around. Changing base types re-triggers the search against bases for the new type. The modal grows down only as descriptions are added, to keep it well positioned.
This modal could easily be adapted to replace the "Craft Item" workflow as well, if desired.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pob.codes/b/1AN2oaXLaWC
Before screenshot:
After screenshot: