Add support for hiring permanent mercenary - #10356
Open
ZenJediMind wants to merge 3 commits into
Open
ZenJediMind wants to merge 3 commits into
ZenJediMind wants to merge 3 commits into
Conversation
|
There are no screenshots in the PR description by the way |
ZenJediMind
marked this pull request as ready for review
September 19, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9984.
Description of the problem being solved:
Permanent mercenaries were not hireable in PoB.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/xz9HuGz0QQKc (https://www.reddit.com/r/pathofexile/comments/1w4qcl0/int_stack_crit_doryani_storm_call_luminary/)
https://pobb.in/R6swmFNSF2Gi (Aura Bot Destructive Link)
https://pobb.in/lPItlPaarCWV (Rathpith KBoC Flame Link)
https://pobb.in/CrpAUBEJYjvE (Manyshot Flame Link)
Before screenshot:
After screenshot:
Controversial changes
As this PR is quite broad and touches a lot of PoB, it has a large number of changes across a lot of systems. These changes are what I view as the most controversial. These also happen to be what introduces the most complexity.
What: Config tab now has an actor selector. An actor is either the player or the mercenary.
Why: Configuration of Merc vs Player can be different (Though they do share the same enemy - this also adds complexity). Along with that comes the provenance "By You" for determining source of an effect, also a lot of additional complexity from that.
I strongly considered trying to just undo and get rid of all these config changes, hindsight it probably wasn't worth the reward for the level of complexity.
What: Items tab, item set selection, is now just changing the view, not which set is actually equipped.
Why: To support trade for these items and the trade query, we need to be able to select which item set to search for, and know which sets are currently equipped. Now its kinda a little out of the way, in the manage section.
Considered but not done
Considered: Trade query weighted stats, letting you select weighted stat per actor
Not Done: Seems overly complicated and probably unnecessary
AI Usage Disclosure: Generative AI was used in the development of this.