Fix trader pearl slot, row hiding logic, and auth label - #10277
Merged
LocalIdentity merged 2 commits intoAug 23, 2026
Merged
Conversation
Include the boundary row when calculating visible Trader rows so no slot remains permanently hidden. Use the first visible ring slot when evaluating Pearl of Tsoatha results from a pasted trade URL. Preserve an explicitly selected ring slot when one is available. Add regression coverage for Pearl evaluation without a prior ring selection.
LocalIdentity
merged commit Aug 23, 2026
fe918a9
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.### Description of the problem being solved:
This fixes:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: