Fix allocated nodes appearing in unallocated power report list - #10270
Merged
LocalIdentity merged 1 commit intoAug 23, 2026
Merged
LocalIdentity merged 1 commit into
LocalIdentity merged 1 commit into
Conversation
Keep Show Unallocated aligned with its label while preserving negative-power entries in Show Allocated. Extract this independent fix from the Weighted Score work because the bug already exists on the upstream base. Related issue 3810 covers a broader refresh problem and is not closed by this change.
LocalIdentity
approved these changes
Aug 23, 2026
LocalIdentity
changed the title
LocalIdentity
added
the
pob2
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 30, 2026
… list (#2476) * Apply changes from PathOfBuildingCommunity/PathOfBuilding#10270 * Fix port --------- Co-authored-by: mcagnion <mcagnion@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3810 (partial overlap; this does not close the issue).
Description of the problem being solved:
Allocated passive nodes could appear in Show Unallocated when their computed power was positive, so the report did not match the selected mode.
Explicitly exclude allocated entries from unallocated modes while preserving Show Allocated behavior, including allocated nodes whose removal power is negative.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: