Fix Mana cost efficiency rounding - #10254
Merged
Merged
Conversation
PoE rounds flat upfront resource costs to whole values after cost efficiency is applied. PoB was not rounding so it retained a fractional result causing costs such as 12 mana with 25% efficiency to appear as 9.6 instead of 10.
3 tasks
LocalIdentity
added
the
pob2
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 29, 2026
* Apply changes from PathOfBuildingCommunity/PathOfBuilding#10254 * Fix test * Comment * Fix test --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
PoE rounds flat upfront resource costs to whole values after cost efficiency is applied.
PoB was not rounding so it retained a fractional result causing costs such as 12 mana with 25% efficiency to appear as 9.6 instead of 10.
Link to a build that showcases this PR:
https://pobb.in/GlAR21JdjdSZ
Before screenshot:
After screenshot: