Fix mirrored items missing "Mirrored" text when using API character import - #10237
Merged
LocalIdentity merged 1 commit intoAug 23, 2026
Merged
LocalIdentity merged 1 commit into
LocalIdentity merged 1 commit into
Conversation
LocalIdentity
approved these changes
Aug 23, 2026
LocalIdentity
changed the title
LocalIdentity
added
the
pob2
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 30, 2026
… character import (#2475) * Apply changes from PathOfBuildingCommunity/PathOfBuilding#10237 * fix port --------- Co-authored-by: AdamZ-8113 <AdamZ-8113@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # N/A
Description of the problem being solved:
Mirrored items were not displaying the "Mirrored" tag when imported via the character import workflow. This is because GGG's item API uses the
duplicatedfield on mirrored items, but the character import workflow was only checkingitemData.mirrored.This maps
itemData.duplicatedto PoB's existingmirroredstate while retainingitemData.mirroredas a compatibility fallback.The existing 3.29 item API import test now supplies
duplicated = trueand verifies that the resulting item is mirrored.Steps taken to verify a working solution:
Halnao#2882, characterHaL_Allflame. They have a rare ring namedDeath Nailthat has the mirrored tag. Viewable on PoE.Ninja here https://poe.ninja/poe1/builds/allflame/character/Halnao-2882/HaL_AllflameLink to a build that showcases this PR:
See above
Before screenshot:
After screenshot: