Fix Toad's Price affecting non-utility flasks - #10213
Merged
LocalIdentity merged 2 commits intoAug 23, 2026
Merged
LocalIdentity merged 2 commits into
LocalIdentity merged 2 commits into
Conversation
mcagnion
reviewed
Aug 23, 2026
| mergeBuff(srcList, flaskBuffs, baseName) | ||
| mergeBuff(srcList, flaskBuffsPerBase[item.baseName], baseName) | ||
| if not isUtilityFlask then | ||
| mergeBuff(srcList, flaskBuffsNonUtility, baseName) |
Contributor
There was a problem hiding this comment.
[P2] Keep the all-flasks-disabled flag authoritative
Codex: Adding recovery modifiers to flaskBuffsNonUtility also makes them apply when FlasksDoNotApplyToPlayer is set. With Toad's Price and Umbilicus Immortalis, both flags are active; the utility-only branch is evaluated first, so an enduring Divine Life Flask gives the player 685.7 life/s even though Flasks do not apply to you is active. Before this change, the same probe returns 0. Could we give FlasksDoNotApplyToPlayer precedence and add a regression test for this combination?
LocalIdentity
approved these changes
Aug 23, 2026
LocalIdentity
merged commit Aug 23, 2026
afbd35e
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10185 .
Description of the problem being solved:
Delirium Ascendancy's
Toad's Priceis affecting recovery rate for life/mana flasksSteps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe1/pob/970d1
Before screenshot:
After screenshot: