Skip to content

Add support for adding vestigial implicits #10156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 16 commits into from
Aug 23, 2026
Merged

Add support for adding vestigial implicits #10156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d5a4f37
Add support for adding vestigial implicits
vaisest Aug 6, 2026
7b2bc85
Prevent adding item to itself as vestigial
vaisest Aug 6, 2026
f1f33eb
Cleanup
vaisest Aug 6, 2026
9499715
Fix shavs + Infernal Mantle mod id
Aug 7, 2026
d216f5d
Fix equality comparison
vaisest Aug 6, 2026
a2d1c4e
Add "Core drop pool" filtering to vestigial implicits and unique db
vaisest Aug 7, 2026
9a6bdbf
Fix (hopefully) all the rest of the core drop pool uniques
vaisest Aug 7, 2026
e4368a7
Fix stasis prison and typo
vaisest Aug 7, 2026
8d5422c
Regen modcache
vaisest Aug 7, 2026
c1c33b9
Cleanup
vaisest Aug 7, 2026
c424d0e
Remove delve implicits
vaisest Aug 9, 2026
e111723
Move popup code to its own module and remove various bits of dead code
vaisest Aug 9, 2026
ab60d68
Fix random sorting on vestigial mods
vaisest Aug 21, 2026
9ce2b01
Fix mod double up
Aug 23, 2026
8c39baa
Fix tooltip to show stat difference of replacing the implicit
Aug 23, 2026
5a0c149
Merge branch 'dev' into add-vestigial
Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Classes/ItemDBControl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function ItemDBClass:ItemDBControl(anchor, rect, itemsTab, db, dbType)
self.controls.requirement = new("DropDownControl"):DropDownControl({"LEFT",self.controls.sort,"BOTTOMLEFT"}, {0, 11, 179, 18}, { "Any requirements", "Current level", "Current attributes", "Current useable" }, function(index, value)
self.listBuildFlag = true
end)
self.controls.obtainable = new("DropDownControl"):DropDownControl({"LEFT",self.controls.requirement,"RIGHT"}, {2, 0, 179, 18}, { "Obtainable", "Any source", "Unobtainable", "Vendor Recipe", "Upgraded", "Boss Item", "Corruption"}, function(index, value)
self.controls.obtainable = new("DropDownControl"):DropDownControl({"LEFT",self.controls.requirement,"RIGHT"}, {2, 0, 179, 18}, { "Obtainable", "Any source", "Unobtainable", "Vendor Recipe", "Upgraded", "Boss Item", "Corruption", "Core Drop Pool"}, function(index, value)
self.listBuildFlag = true
end)
end
Expand Down Expand Up @@ -126,6 +126,8 @@ function ItemDBClass:DoesItemMatchFilters(item)
return false
elseif (self.controls.obtainable.selIndex == 7 and not (string.match(source, "Vaal Orb"))) then
return false
elseif (self.controls.obtainable.selIndex == 8) and item.source then

@mcagnion mcagnion Aug 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex found a possible data-contract edge case here: this condition appears to treat missing Source metadata as a positive core-pool match. At the merged head, The Hateful Accuser, The Queller of Minds, and The Selfish Shepherd have no Source line, so they match this filter even though Nameless Rings are obtained from Rituals.

This seems to establish false positives in the global Unique DB filter, although it does not by itself show that the audited Vestigial armour receiver set is incorrect. Would it make sense to distinguish explicit core-pool metadata from unknown metadata—for example with Source: Drops anywhere—and cover a restricted item with missing Source in a regression test?

return false
end
end
if self.dbType == "UNIQUE" and self.controls.requirement.selIndex > 1 then
Expand Down
Loading
Loading