Add crafting support for Cane of Kulemak, Replic Paradoxica, Queen's Hunger and That Which was Taken - #10152
Conversation
vaisest
changed the title
b109c8b to
ca4664a
Compare
# Conflicts: # src/Data/ModItemExclusive.lua # src/Modules/Data.lua
# Conflicts: # src/Modules/Data.lua
# Conflicts: # src/Modules/Data.lua
# Conflicts: # src/Data/Uniques/Special/Generated.lua
ca4664a to
df1f3fe
Compare
e06bc4d
into
PathOfBuildingCommunity:dev
LocalIdentity
changed the title
| crimsonStormMods[modId] = mod | ||
| if mod.affix == "Chosen" then | ||
| veiledMods[modId] = mod | ||
| caneOfKulemakMods[modId] = mod |
There was a problem hiding this comment.
[P1] Include Chosen prefixes in Queen's Hunger's pool
queensHungerMods is populated for Catarina's and of the Order, but not for Chosen. Queen's Hunger's Catarina's Veiled prefix can also unveil generic body-armour Chosen mods. For example, current item data includes 9% Chance to Block Spell Damage (JunMasterVeiledSpellBlockPercent____), one of six compatible Chosen IDs that CanHaveMod accepts here but which are absent from item.affixes. Since UpdateAffixControl enumerates only item.affixes, the rare-like editor cannot recreate that item. Could queensHungerMods[modId] = mod be added in this branch, with a focused offered-mod regression test?
AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction.
3 participants
Description of the problem being solved:
After this, all the fitting uniques should work with the rare crafting UI
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: