Skip to content

Fix crash when an item grants a skill below its lowest defined level #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juddisjudd wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −1
Open

Fix crash when an item grants a skill below its lowest defined level #2543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,14 @@ local function getGrantedSkillLevel(gemData, maxLevel, characterLevel, modDB)
return level
end
end
return 1
-- Some granted skills only define higher levels (Pinnacle of Power has only 20)
local lowest
for level in pairs(gemData.grantedEffect.levels) do
if type(level) == "number" and (not lowest or level < lowest) then
lowest = level
end
end
return lowest or 1
end

local defaultAttackSlots = {
Expand Down