Skip to content

[pob1-port] Fix reimport of skills showing old gem data #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Aug 30, 2026
Merged

[pob1-port] Fix reimport of skills showing old gem data #2491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a630b2f
Apply changes from https://github.com/PathOfBuildingCommunity/PathOfB…
vaisest Aug 30, 2026
c1c539a
Fix port
Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions spec/System/TestImportReimport_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,24 @@ Fireball 20/0 1
assert.is_false(groupsByGem.Fireball.enabled)
end)

it("clears the stale socket group selection when reimporting skills", function()
build.skillsTab:PasteSocketGroup([[
Fireball 20/0 1
]])
runCallback("OnFrame")

local oldSocketGroup = build.skillsTab.socketGroupList[1]
assert.are.equal(oldSocketGroup, build.skillsTab.displayGroup)
assert.are.equal(oldSocketGroup, build.skillsTab.controls.groupList.selValue)

reimportSingleGem("Linen Wraps", "Gloves", "Dark Effigy")

assert.is_nil(build.skillsTab.displayGroup)
assert.is_nil(build.skillsTab.controls.groupList.selIndex)
assert.is_nil(build.skillsTab.controls.groupList.selValue)
assert.are_not.equal(oldSocketGroup, build.skillsTab.socketGroupList[1])
end)

it("imports item socketed jewels using jewel socket order instead of raw socket index", function()
build.importTab.controls.charImportItemsClearItems.state = true
build.importTab.controls.charImportItemsClearSkills.state = true
Expand Down
3 changes: 3 additions & 0 deletions src/Classes/ImportTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,6 +1123,9 @@ function ImportTabClass:ImportItemsAndSkills(charData)
t_insert(preservedSocketGroupStateByKey[key], snapshotSocketGroupReimportState(socketGroup, index == self.build.mainSocketGroup))
end
wipeTable(self.build.skillsTab.socketGroupList)
self.build.skillsTab.controls.groupList.selIndex = nil
self.build.skillsTab.controls.groupList.selValue = nil
self.build.skillsTab:SetDisplayGroup()
end
self.charImportStatus = colorCodes.POSITIVE.."Items and skills successfully imported."
--ConPrintTable(charItemData)
Expand Down
Loading