Skip to content

[pob1-port] Allow Intuitive Leap -likes to shorten power report distance #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

[pob1-port] Allow Intuitive Leap -likes to shorten power report distance #2469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/Classes/CalcsTab.lua.rej
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
diff a/src/Classes/CalcsTab.lua b/src/Classes/CalcsTab.lua (rejected hunks)
@@ -642,12 +642,6 @@ function CalcsTabClass:PowerBuilder()
end

for _, node in ipairs(masteryNodeList) do
- local distance = 0
- for _, pathNode in pairs(node.path) do
- if pathNode ~= node then
- distance = distance + 1
- end
- end
for _, masteryEffect in ipairs(node.masteryEffects or { }) do
if masteryEffectCanBeAssignedToNode(node, masteryEffect) then
local effect = self.build.spec.tree.masteryEffects[masteryEffect.effect]
@@ -660,7 +654,7 @@ function CalcsTabClass:PowerBuilder()
local output = cache[effectNode.modKey]
node.power.masteryEffects[effect.id] = { }
local effectPower = node.power.masteryEffects[effect.id]
- calculateAddNodePower(effectPower, distance, node, output, function()
+ calculateAddNodePower(effectPower, node.pathDist, node, output, function()
local pathNodes = {
[effectNode] = true
}
10 changes: 10 additions & 0 deletions src/Classes/TreeTab.lua.rej
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
diff a/src/Classes/TreeTab.lua b/src/Classes/TreeTab.lua (rejected hunks)
@@ -1091,7 +1091,7 @@ function TreeTabClass:BuildPowerReportList(currentStat)
if isAlloc then
return #(node.depends or { }) == 0 and 1 or #node.depends
end
- return #(node.path or { }) == 0 and 1 or #node.path
+ return node.power.distance or #(node.path or {}) == 0 and 1 or #node.path
end
local function addReportEntry(node, name, nodePower, pathPower, pathDist, isAlloc, pathPowerStr)
t_insert(report, {