Skip to content

Fix ModifierThreshold upper tag#1949

Open
avtobus32 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
avtobus32:fix-modifier-threshold
Open

Fix ModifierThreshold upper tag#1949
avtobus32 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
avtobus32:fix-modifier-threshold

Conversation

@avtobus32
Copy link
Copy Markdown

@avtobus32 avtobus32 commented May 23, 2026

Fixes # .

Description of the problem being solved:

MultiplierThreshold with "upper=true" was applied only if value exact match threshold, while it should use threshould as upper limit
I have experienced this with mod "Projectiles have 40% increased Critical Damage Bonus against Enemies within 2m" that should apply whenever the distance is <= 20 units, but was applied only when distance is exactly 20units

Steps taken to verify a working solution:

  • Removed "and tag.exact" check that i couldnt find any reference to, and i believe it is dev/testing product of Adding support for Uhtred's Augury / Exodus / Omen: bbffdae

Link to a build that showcases this PR:

https://pobb.in/3rOxLc4Ge0WJ

Before screenshot:

After screenshot:

MultiplierThreshold with "upper=true" applies whenever mult <= threshold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant