Skip to content

Adds combo#1946

Open
Eucelia wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
Eucelia:eucelia/combo-support
Open

Adds combo#1946
Eucelia wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
Eucelia:eucelia/combo-support

Conversation

@Eucelia
Copy link
Copy Markdown
Contributor

@Eucelia Eucelia commented May 23, 2026

This PR adds support for damage calculation for combo payoff skills.

Supports:

  • Culmination/Combo Finisher Gems
  • Chakra of Impact Node for Increased Damage per Combo Consumed
  • Combo can be specified separately in configuration similar to Rage.
  • Only combo up to the limit for that gem will be considered.
  • Only skills that are combo payoff skills are modified by combo damage modifiers.

Tests included

Details:

  1. Culmination support gems now work correctly.
image

I've tested this by setting Combo Stacks to 20 in Configuration and then using the Culmination I support gem (which has a max combo of 10). Testing against manually applying a 30% damage buff (3% for each of the 10 combo) results in the same DPS.

  1. It also adds support for the combo aspect of Chakra of Impact.

I've tested this by manually modifying the attack damage portion to 0 and then toggling the node.

image

The storm wave (with culmination support) dps goes to 1365. This is the same as when you unallocate the node and apply a custom 40% increased damage modifier.

image
  1. Skills that do not have Combo Stacking are not affected by any combo buffs.
    Tested by confirming that a different skill that does not have a combo stacking support has no damage increase when Chakra of Impact is allocated (with the attack damage portion set to 0).

Sample build

eNrtPNty20ayz9FXoFi1VbsVmsL9opKzRZGSraxoKaRs2efFNSKGJCJcGGBAiU7tv5_uGdxIEyAgb7bOw8mDTGD6Nt09PT3dg5z_8yXwpQ2NEy8K3_aUgdyTaDiPXC9cvu19vL96Y_f--cvJ-R1hq9vFRer5OKL-cvLTOX-QfLqh_tuervSkgHjhLJo_UfYujtI1UOtJG48-TyKXvu1dT-5up_c9iZF4SdmnnKP8FaDmKxKTOaPxDVIbpiwSOCxOKYz6JEk-kABejOPUc3sSSeY0dEfl-1tA92kPxPrp_M4nWxrPGGHShvgpjCqKYQ8cVVMtw1ItuyclMPi2N4RpkyUdkwD-9k5fhXyRxgk7RmGgWJaRI87WlLr1sOpAzyHvYnq5WNA58zZ0FHtstCLhvJ6NOXD0ArcFvFqFnaQ-89a-R-NaeMPMEd4fpa1opj4wNVUxLMV0CqnuI0b88d2sFk_ehYxYVw4PHltd-KDhJi7qwNJNy7ItU9G0HPN6GXqMNqEBS2ugWbajGY4m21WWrZDr5L2LvCQKOwucq6iVPkep78PCbQU7pQmNN4R5zULVqGMUBY9e2GyAchXFlNwuhJdPieulyYSymCb1mMU6mpCQjKKEHZ8PQt7RGEIGa0RQZHkg25axhzej8wiCTVdWHTFvvAVtD9lmOvsIXaV53TwuZ23hOhN-nUBTCM3tIGdR6jdCqrJSwLL6QGnlQGP60hDorXK9_dEIWTC9Dutls80KuSZAuZRuE-EabxGMY-8xZfXR3pbtga2ZpmHANqk5OwHq8v1dLZ5jFTq4W20Tb078CXnxgjSAHeaePNF62UxDKX11uWIhBLdX4F55MX0F2ijy3bZolUnCphklbfFUWy2jihe-J6E7nM9TSHS2LWxL4qeQJknbYA_h-hhGZR4YHerThEqiMz9D0Otw3pbqxzDO5GmLMYVQgKnYo0-bAvthJllEaRcPp3RJw4zdth3KDaXz1Tuw3pQ0LB-1DAW4f7QIVKhZBG3S7B7VFpqtqGkX45ianIFSReyoKERpp6iKgLO1B1lre8hu09_Hae0nlyGNl9vZyqO-2w0619eIrFs6QBW7yRFq2HWyURW1na129t923Ap_vdyQpNXGJPQgoNupYENceuTsUjomhYNEJ4y7OPodz2t-NzSYhu93x3gltzFd-IgWoQFh22yN0ZbBMA6iNG5pPQHcynh5jiCO21PqpvPG_EUptqLiGH3hR_OntvMosLi2O6EOGSPzp3HkLruZtBPGrnyzdL2GeIVL4QiBN4ZczX8gA_DapMcl7C0s46Y4VWGAmVJbBiVsBwZF9teWyx7CMVbyTvLWeiol8DEGynfmnECYDGC74ZWiSdSwkQyKYsAOzsMKYsLHBOY4e_J8vxa_WmlKKLhMqyO4qivmwLItR9VMpzz3X6W-37mGwZGqJYyMCpf7SOlkxqI4kB7IhsIbhL8jMbyGBwgoc8BrIinrzkCXbce2LPM_QfDg7C5owiRRGpJwioepVtgeD4HRM3jTCkuo9QbSDkHDsaPFEo9p-G3bmv4OeCsGl6ELJxjwtNY89jFKNhfpYpFIj_D3BpYZahRORwktHqLgkbDsSWDcewFs6UkyJoyA-rFSfeX5jMZjgEIeXFI3Oxd_IrFHQqbwJbr3UhXrlpJ4vkIWV8T3HyHic7sWbzPG56e8VI6_rhkNEonwZY6_Z5QJSqvoGac_9iAIxLgUk7z6nSZUlDseKFlHIcdYED_Jqt1IRfJcpILPP01BQLY9k6bD6eXJpc-DAvElIL5YnAzp0kuk31LwQBon_NUoJgtG3TMJuZ1AIFh4L2fSn6DyJT2TB8a_byLYcoeuS13cAMTee_8c4XnU_tqMgAF9F6EZvgjNe0gzsPEhJMgaYkoS6ortlsc-rRYay9yYPsxY7D1lm-xB6Hd-9Eh8nv3xNf6OBrwvkckj7KCfgBp9rmr5hA9P6R9nkuWcXAdr35t7LDmTlJM_GVkmZ4-YO_y7wuLnvyvqG8X-x98kFkk8s8AeCAh0AopIJNvA94qmSKhzSahDDFkyH5ItCbW7O4QjqixLhR7z4Z_Vgc5Z5TqQ3ntMEio4UdS_SV6uSUmoUuK6PPnZRCQ-OylaSODkEleLxPWSoL-dwwY1xXlJfHa4KUHaJRySr7oGCPUohHYUQj8KYRyFMI9CWFkEOcXlVqw7WIsNy7O6Ks9FX-za_Ti9kcLIpdc4OdUyIc7B7hDcPcIABo-Qt7N-pc-gcTGeiTbzI8ZBEVPOAW_oUlJ3STTCQ7bdCf7KJ8mTpHTAQIm6wGNYD16BoXbG0DrPu4bHAVOqimPrDaYU482mCVKfsg4yvqd-0Alh2FHRF5G7lbLDXHssiJ4b2Ni7sIlYF_gpBjalvWlMxTGbTMPHj3Ps4j4iFkiqNHuGzL-DKqjPumpCfYVcx1GUPZT2-rYcU25QNx9uI6RSpzwRhCHQipwuJi5EYEy5Hijue4lIuXimhb9GxJ8nImSH65RlTAIvmX_F3BEvGmCuGfMLD5dXV5ej--tPlxmrKgpP3r-GafBIYT2If4td7nwmSipSkj4m4ufb3iePPvOdckwZ8fwEk1LfJ2vYZ3c2CQ4zo1hjaaDGoWDfzm4b1NAqAeopXb7QGCs_D6C12KO1chXjR4QSDLG4hxl2HbWym3-IkMg7RiRhvKxYp6nK5YlDVDC_qZ3OqKwYH8KFvI34tZyz0SOaYNs1TdZ07i28OebzzSa_B2gB1aCXvOdTb--dcs8hGvxCRB0BMViPLG4n1GFnow1a5cffWq2K0Xr0MZ2T2rmLwXrkolIdhaCmOioFVAOlD1HInRwWzdDz8UxVa1k4cxUg9QRv2YrGouJTS2kCMSoHaVw4oj1bS6cC0aAr7OnVaajs9x1C5U2rujmUDa2Di0a0cWpXu9e8ZHfaLXX2-L4lc4iUKNbV6nCn8HfQDFmeVGOCakn84EyylkfdJHY6IgcXCo_Bw03kuTwa1C2ZPbCmoAGb-4-T4RXt_wCZomnx47R4cl9r6Wy0Hv0j8_Dcf4CKKNi0IoJL6sco4Mr6MQr8WPRq7Ol-ElLiTpvTj7z2dxh5tzJ4eNVnJcFXUxCFy1ej87rqq7F56Ad_5lW-pthfwDTET5aGY1BG08JoSYqLdTh-lLPrREvsggdn2pliVhHkN2YaA0D1Uk0tIdjG3zckiu0oFf2a95T4eIsz8n-M4P7NoB8iht32dE1CNyd3eyg9L-3QUntwVAeavJ49xqb-j-owpMH2AKF6uc5P8wMdHP0oxSOW9C2Kgs9ve280R5cHtqxqmqqbeFMUB7687WH_SDYM09YUTba0xnK7qN7PGBzt1jTmXYRIELoRN90VW8gBB4IoZhJ9wX-wp7PN53-aC5cV-rHPnVcCz_FBYih5eQMeW1q8hkji7bC82o6n4tADp8KjNQhoyIqs92Eycl81bLWvW4pp9xVF04y-Ylmq3ldkRVP6vNjUNxzNVPumalpW31R0WeurliUbgOVYJsADbF_RYRj-6rrZ1wEGAA3V6BuyjAR0QwVimgasDMNS-rqtIb5tWVpfVy1T6Ruqpjh9PNL3Nc1S1T4vWfZ1w1E1ZATC6KZh6H1eZOnblgriWroCcA6Q0ixTdWBCYBrAsW0UTnGAlmogiG7BjFRVU_tIWncczYZZGfyv7GgAoThA2pZlYCzbMujCsCwQ35B1u685qAvNgYn2NcUy8b2DvTnx8QAEue11yGgcEh8Vzb8sULKPDa55YVkK4DRK422Wg2Mlg-xap4CvEFLyku_H6Q3_8dOKsXVydnr6_Pw8WBO2ihb0xfPpAHzrdA3Y4CJveHHhDfrF6RD-u1j-dvEhudXHvy__dRWvhjeX7tXdiN5_ouNQ39x_shyW3D6y6LdE1tJvq_Ry9G28_nBvPChfPj1b25dN9Hny-cX-srTWX99YH35Pv6WKGvzPx6G6ZNqX0a9PG_X2283ESa--TBLNIjf2ciQnk5n5602gfNZGjw-_6g9jdaE8e19UI6GLi89k8dtwyCd2ms8sq_8kWTkHI0zsgauKaZ8X5458QPJC9kH4Mi-5fKj6NXdpYV7hxsI5m91YeJ1wYOGMwhGE7woXytyW-2HmfdzvMkdGt-cOJ5aT8PfS4YQXVx1OeLdwO-FwwndrHc6lL_msM02d7qjq_BSDAo9tGDXwx4eIiTF8mT-ci66LlEDAeUeD5GI7vptd4blm99Z9HnZEVanSYEzXa4GKhQcQZ3hz09ullkdBly5I6rO88wVxKIqD4nZudTzrgmH9TsS3jOtu94O3yvH7oGEpGpdr7x2P7XzAC-d-6tLrMOu255L55BHlqfbqaYi3P_NdI3M-EE3aiGYtrkoOXwUXTT4lJ7sURcgJZcQljIjy4SkQOc1bgBUKfLHuUBUNbNzC0lAoPPsuSpV70h-livZk3ZFFLbYg2JlAg9chOE62A1RfZToSOwMJsu1l_xbB9yoYpX7ghTxVzDyhuy4KD6oQq-pDjFcGaxWj_Jf0UpFFui7WHzfqX-WbCTfFM5hCEsvm_130sIv-xXaoTKW8MHFA70_UB536wziJQizyCOVNvDA753qQkgqgKCyButkoKY3UxG5vgpWFFQQ4uouaNNp0n-x_b83lckrFHP8qe2cHjszgkFDBiYeHpFaWn64iMkHV7ZlcaJu6OP56Qx-mXmfhAvr_qE1RPklM5ztjZj9FSy574AkLPxZJM8g9hu4Gywr3cEhOCrNB_sOy2AzJiA_8yHoN-fXOQWoUhQtvmeU04iFLajjr4o3EPOZTXinE1GT3-sVO66_41HUkDnd5K08tGpNV8HkK8TyYRG5Stgl1uXplxhWXbHJkMOCcriLfheOjIEHxlFu9P1qwlOuRSjHzUyp7B3-IS_FOkPtdB7IljSG4dnsCeCj10D6jKI7TNTYNR_EWjs68flcQaJjGbB7x8zSZPyWtWHJl8ayzBLfVeniXwlq9gp3lOx5yG4vk3dQcS7PNI2h5pb8QTi5v6TSZgHdTtx_BY6YUvybxt-31UbmnXeAYx-a3d52uxHRMox418Zaef7vgNc7vDH2EY36P8tCaqjNCXHa0Cxu0QcJrbA-U8I_W9k2vtlpX-O01rAmXY48wtM2ov6jM1mghRtZ8La1yBEd0sAtwS24lKtZ5w9c4Dl4SvMNaYqHbNuxGaYyxYre9Vq6r1o7X2WUrnwu0QhqtcN_pGFxwMbXViXBr8cFJ5Pv8dmDVeg2BbxXNn7qKVrQBCwTFMlpMp9MK51i7H9N0wSxv9XbBKnzikObPT4ttXJR4-dMvJ-en3_1_R_4XQ1H_gQ==

@Eucelia Eucelia changed the title [WIP] Add support for combo Adds combo May 23, 2026
@Eucelia Eucelia marked this pull request as ready for review May 23, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant