Adds combo#1946
Open
Eucelia wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for damage calculation for combo payoff skills.
Supports:
Tests included
Details:
I've tested this by setting Combo Stacks to 20 in Configuration and then using the Culmination I support gem (which has a max combo of 10). Testing against manually applying a 30% damage buff (3% for each of the 10 combo) results in the same DPS.
I've tested this by manually modifying the attack damage portion to 0 and then toggling the node.
The storm wave (with culmination support) dps goes to 1365. This is the same as when you unallocate the node and apply a custom 40% increased damage modifier.
Tested by confirming that a different skill that does not have a combo stacking support has no damage increase when Chakra of Impact is allocated (with the attack damage portion set to 0).
Sample build