docs(dip-26): align collateral payout reuse rule

[thepastaclaw]

Summary

• Aligns DIP-0026's collateral reuse rule with Dash Core's destination-equality check, including P2SH collateral destinations.
• Updates the corresponding test case and security rationale to use the same terminology.

Context

This is a documentation follow-up to dashpay#184. Dash Core compares the extracted payout and collateral output destinations rather than limiting the rule to P2PKH key IDs.

Validation

• npx markdownlint-cli2 dip-0026.md --config .markdownlint.json
• git diff --check pasta/codex/masternode-reward-shares..HEAD

Summary by CodeRabbit

• Documentation
  • Clarified payout validation rules to prohibit destinations matching the collateral output destination when comparable.
  • Updated invalid test-case guidance to cover reuse of owner keys, voting keys, or the collateral destination.
  • Revised security considerations to describe collateral destination protections and associated control over funds and higher-value functions.

[coderabbitai]

📝 Walkthrough

Walkthrough

DIP-0026 updates payout-script validation, invalid test-case wording, and security considerations to compare payout destinations with the collateral output destination rather than referring to collateral key reuse.

Changes

Collateral destination semantics

Layer / File(s)	Summary
Collateral destination comparison wording dip-0026.md	Validation rules, test cases, and security considerations now prohibit payout destinations matching the collateral output destination when the comparison can be performed, while retaining owner and voting key restrictions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: udjinm6

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately describes the main documentation change to the collateral payout reuse rule.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

✅ Action performed

Reviews resumed.