chore: configure Papyrus development tools, skills, and agents - #4
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d08ef7f11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,8 @@ | |||
| [agents] | |||
| max_concurrent_threads_per_session = 2 | |||
There was a problem hiding this comment.
Replace the invalid agent concurrency setting
When Codex loads this trusted-project configuration, it fails before starting a session or MCP server: validating agents.max_concurrent_threads_per_session=2 with codex exec --strict-config reports invalid type: integer '2', expected struct AgentRoleToml in agents, whereas agents.max_threads=2 is accepted. Rename this setting to max_threads; otherwise Codex is unusable in the repository rather than merely failing to enforce the intended two-agent limit.
Useful? React with 👍 / 👎.
| [agents] | ||
| max_concurrent_threads_per_session = 2 |
There was a problem hiding this comment.
Register the custom agent role files
Even after correcting the concurrency key, Codex custom roles must be declared as [agents.<role>] entries with description and config_file; placing TOMLs in .codex/agents alone does not register them. A repo-wide search finds no agents.papyrus_* tables or config_file references, so the advertised client, server, and contract-review roles cannot be selected when delegation is requested. Register each added role under this section.
AGENTS.md reference: AGENTS.md:L56-L58
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The workspace had no shared agent guidance or repeatable quality-check commands, and local Flutter differed from the client CI version. Add a project-pinned Flutter SDK, locked dependency setup, a workspace CLI, VS Code configuration/tasks, and a CI workflow for the tooling itself.
Add three focused Papyrus skills and client/server/contract-review agent roles, plus a development guide documenting ownership, the reader dependency boundary, validation, and known gaps. The CLI checks that destructive server fixtures use a separate local test database and prevents overlapping CLI test runs. Dart MCP uses the pinned SDK and can start from the workspace or a nested component directory.
Dependent PRs
Merge these component PRs before this workspace PR, which updates the client/server submodule references to their commits:
513d177).71b21c6).The referenced commits have been pushed to their component repositories.
Validation
Known gaps
The added server format check correctly reports five pre-existing files needing formatting. They are listed in DEVELOPMENT.md and are outside this change. Live cross-device sync, provider-backed OAuth/SMTP smoke tests, and native release builds were not run. MCP/agent configuration may require restarting an existing Codex session.