Skip to content

chore: configure Papyrus development tools, skills, and agents - #4

Merged
Eoic merged 1 commit into
masterfrom
chore/development-tooling
Oct 3, 2026
Merged

Eoic merged 1 commit into
masterfrom
chore/development-tooling

Conversation

@Eoic

@Eoic Eoic commented Oct 3, 2026

Copy link
Copy Markdown
Member

The workspace had no shared agent guidance or repeatable quality-check commands, and local Flutter differed from the client CI version. Add a project-pinned Flutter SDK, locked dependency setup, a workspace CLI, VS Code configuration/tasks, and a CI workflow for the tooling itself.

Add three focused Papyrus skills and client/server/contract-review agent roles, plus a development guide documenting ownership, the reader dependency boundary, validation, and known gaps. The CLI checks that destructive server fixtures use a separate local test database and prevents overlapping CLI test runs. Dart MCP uses the pinned SDK and can start from the workspace or a nested component directory.

Dependent PRs

Merge these component PRs before this workspace PR, which updates the client/server submodule references to their commits:

The referenced commits have been pushed to their component repositories.

Validation

  • Eight workspace CLI regressions pass; ShellCheck and tooling Ruff checks pass.
  • Project JSON/TOML, workflow YAML, and skill frontmatter validate.
  • Client: locked installation, formatting, and analysis pass; 1,387 tests pass with 19 skipped; four web-bootstrap tests pass; web release compilation and Wasm dry run succeed.
  • Server: 340 tests pass with two provider smoke tests excluded; Ruff lint and Mypy pass across 138 files.
  • Reader: 93 tests pass with 21 skipped; generated example changes from dependency setup were cleaned up.
  • Dart MCP initializes and enumerates 25 tools from both the workspace root and client/app.
  • Workspace, client CI, and release Flutter pins agree; staged whitespace checks pass.

Known gaps

The added server format check correctly reports five pre-existing files needing formatting. They are listed in DEVELOPMENT.md and are outside this change. Live cross-device sync, provider-backed OAuth/SMTP smoke tests, and native release builds were not run. MCP/agent configuration may require restarting an existing Codex session.

Copilot AI balanced review requested due to automatic review settings October 3, 2026 00:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d08ef7f11

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .codex/config.toml
@@ -0,0 +1,8 @@
[agents]
max_concurrent_threads_per_session = 2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace the invalid agent concurrency setting

When Codex loads this trusted-project configuration, it fails before starting a session or MCP server: validating agents.max_concurrent_threads_per_session=2 with codex exec --strict-config reports invalid type: integer '2', expected struct AgentRoleToml in agents, whereas agents.max_threads=2 is accepted. Rename this setting to max_threads; otherwise Codex is unusable in the repository rather than merely failing to enforce the intended two-agent limit.

Useful? React with 👍 / 👎.

Comment thread .codex/config.toml
Comment on lines +1 to +2
[agents]
max_concurrent_threads_per_session = 2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Register the custom agent role files

Even after correcting the concurrency key, Codex custom roles must be declared as [agents.<role>] entries with description and config_file; placing TOMLs in .codex/agents alone does not register them. A repo-wide search finds no agents.papyrus_* tables or config_file references, so the advertised client, server, and contract-review roles cannot be selected when delegation is requested. Register each added role under this section.

AGENTS.md reference: AGENTS.md:L56-L58

Useful? React with 👍 / 👎.

@Eoic
Eoic merged commit 7ca8bdc into master Oct 3, 2026
2 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T00:29:09.637470Z 3d08ef7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic deleted the chore/development-tooling branch October 3, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants