Repository navigation
fix: respect mobile auth insets and unify goal sheets - #39
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d61e023f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| body: SafeArea( | ||
| top: false, |
There was a problem hiding this comment.
On devices with nonzero horizontal safe-area padding that still select MobileAuthLayout—for example, a notched phone in landscape at 600–839 logical pixels—the default left and right settings also inset the entire column. This narrows CompactAuthHeader and leaves surface-colored gutters beside the formerly full-width clipped hero, even though this change only needs bottom protection; disable the horizontal insets or apply the bottom safe area below the hero.
AGENTS.md reference: AGENTS.md:L22-L24
Useful? React with 👍 / 👎.
Summary
Mobile authentication footers could sit behind Android navigation controls. Add a bottom safe area to the shared mobile auth layout, covering login, registration, and password recovery while retaining keyboard resizing.
Use the standard title/close header for active and completed Goal details sheets. Give completed goals a Done action with Delete as the secondary action, and allow labels to wrap on narrow phones. Include the pending lockfile quoting normalization; the reader revision is unchanged.
Testing
../tools/papyrus test client -- test/widgets/auth/auth_page_layouts_test.dart test/widgets/goals/goal_details_sheets_test.dart: all 11 tests passed.../tools/papyrus check client: formatting, analysis, and four web-bootstrap checks passed.git diff --check origin/development...HEAD: passed.The regressions simulate Android navigation insets and an open keyboard, and check Goal sheet actions at 320 and 390 pixels, equal button sizing, overflow, and dismissal. The full application suite was not rerun locally.
UI evidence
Inspected locally rendered login, active Goal, and completed Goal screenshots at 390 × 844. No new Android device build was installed for this change.
Compatibility and migration
No data migration or version bump. Goal persistence and authentication behavior are unchanged. Merging into development does not publish a release.
Notes
This PR contains the existing mobile layout fixes. The broader Goals management redesign will be handled separately.
Checklist