Repository navigation
i18n(admin): translate the hardcoded text on 20 more admin screens - #184
Merged
Merged
Conversation
…sting translations
…aid date and the service status
…ds, affiliates, billable items and addon pages
Owner
|
Thank you, @ertugrulkeyvan, merged. Twenty more admin screens now take their text from the translation files. Every key it uses gives the same English as the text it replaces, all five languages have the new entries in the same order, and the hardcoded-text budget went down with it. Full suite green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A second round after #175: the remaining readable English on the admin screens now goes through translations.
HardcodedViewTextTest's ledger for the admin area goes from 132 to 110.What is left is what should stay as written:
SUMMER20,mail.example.com,INBOXandspam@example.com;KB,IMAP,POP3,SSLandSTARTTLS;Translated, in three groups:
Back buttons and the quote's add-item button: clients, products, product groups, projects and quotes now use the existing
common.actions.backandadmin.invoices.add_item.Detail pages:
Invoice and order reuse
admin.search.invoice_titleandadmin.search.order_title("Invoice #:num", "Order #:num").The rest:
The last four reuse existing keys:
admin.billable_items.amount,admin.appearance.logoandadmin.appearance.theme_by.New keys: each is written in en, tr, de, pl and zh, with numbers, names and dates passed as placeholders, so each language orders them its own way.
How
HardcodedViewTextTestledger numbers.__().Tests
HardcodedViewTextTest: passes with the lower ledger (admin 132 → 110).TranslationParityTest,DynamicTranslationParityTest,TranslationCoverageTest: pass. Every new key is in all five languages, no Turkish string keeps an English word, and no new key shadows an existing one.Full suite: 4086 passed. The one failure is the
CurrencyAndBackupTestdb backup test, which fails onmaintoo in my local setup.