Repository navigation
feat(panelica): the mail certificate's host name, and the DNS records a failed one needs - #180
Merged
Panelica merged 6 commits intoOct 11, 2026
Conversation
…ts are told the host name the panel gives it
…asking for it again
…tificate needs, with a button to request it again
…rds it needs, the notice and the retry
Panelica
pushed a commit
that referenced
this pull request
Oct 11, 2026
feat(panelica): a failed mail certificate shows the DNS records it needs, with a button to request it again
Owner
|
Thank you, @ertugrulkeyvan, merged. Reading the panel's certificate status and showing the customer exactly which records to add will save a lot of "my mail app says the connection is not secure" tickets. On top of your commits there is one more (9dbf6b5):
Full suite green. |
Panelica
pushed a commit
that referenced
this pull request
Oct 11, 2026
…reachable fix(hosting): a hosting panel that does not answer no longer gives the customer a 500 lang/*/client.php: the keys #180 added and the one added here are both kept, in that order in every language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two follow-ups to #178, on the Panelica mail certificate.
1. The host name the panel gives the certificate.
This is your note on #178. The panel lets an operator give a domain a different mail host name, and
GET /v1/ssl/domains/{id}/mailreturns it asdata.hostname.mail.<domain>, as now.2. Telling the customer what a failed certificate needs.
mail.,autoconfig.andautodiscover., and each of them is checked. For a domain whose DNS is somewhere else, issuing fails until all three point at the server. We measured this on Panelica 1.0.14: the status isfailed, with anNXDOMAINerror for each name.failed, the email page shows a short notice with the three records to add, each with a copy button:How
PanelicaModule::mailCertificate():panelica_domain_id): status, host name and last error;mailHostname(): prefers that host name, thenmail.<domain>, then the server-hostname guess.mailDnsHelp(): builds the records for a failed certificate, or null.retryMailCertificate(): calls the existingensureMailCertificate().ServiceController:emails()passes$mailDnsto the view only when the account has mailboxes.retryMailCertificate()is the button, behind the client-ownership check andthrottle:3,10, on the routeclient.services.emails.certificate.client/services/hosting/email.docs/guides/connect-a-server.md.The work is split into six commits: the certificate status and host name, the records and the retry, the page, the translations, the docs and the tests.
Tests
tests/Feature/PanelicaMailDnsHelpTest.php, 12 tests:mail.<domain>.Nine of them fail on
main. The existing Panelica tests pass unchanged.Full suite: 4098 passed. The one failure is the
CurrencyAndBackupTestdb backup test, which fails onmaintoo in my local setup.