Repository navigation
Upgrade Electron to 42.x in Electron examples (CVE-2026-115570) - #118
Merged
Conversation
Raise the electron devDependency from ^41.2.0 to ^42.11.16 in the electron and electron-nodeintegration examples. Electron before 42.11.16 does not block the compromised eMudhra intermediate certificates in Chromium networking or Node tls/https/fetch (GHSA-jr5w-w6x2-84p9). The lockfiles now resolve electron 42.11.18, which also clears the other high-severity Electron advisories npm audit reported against 41.10.7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
miguelcalderon
approved these changes
Nov 16, 2026
miguelcalderon
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. The change is limited to the Electron version, and the lockfiles only swap the Electron entry.
I ran the smoke test the description asked for on macOS: npm ci and npm start in both examples on Electron 42.11.18. Both apps opened and loaded the viewer with no errors. The console warnings I saw (missing baseUrl, the Content Security Policy notice) aren't caused by this upgrade. On the first npm start, Electron now prints "Downloading Electron binary..." and takes a little longer, which is expected.
Not part of this PR: drag-and-drop in both examples still reads File.path, which Electron removed a while ago. It would be good to fix that separately.
miguelcalderon
deleted the
support-agent/linear-237d9b21-5afc-4b3a-956c-48918201c91a-97453cea-43f2-4267-98ed-f37ec2d3217a
branch
November 16, 2026 10:31
5 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises the
electrondevDependency from^41.2.0to^42.11.16inexamples/electronandexamples/electron-nodeintegration. Both lockfiles now resolveelectron@42.11.18.Electron before 42.11.16 does not block the compromised eMudhra intermediate certificates in Chromium networking or in Node's
tls/https/fetch. An attacker holding such a certificate and able to intercept traffic could impersonate a TLS server (GHSA-jr5w-w6x2-84p9, CVE-2026-115570, high). The upgrade also clears the other high-severity Electron advisoriesnpm auditreported against 41.10.7.Resolves SECSLOP-9 (Dependabot alerts 1780 and 1788).
Changes
examples/electron/package.json,examples/electron-nodeintegration/package.json:electron^41.2.0→^42.11.16package-lock.jsonfiles: only theelectronentry changed (41.10.7 → 42.11.18).@electron/remotein the nodeintegration example shares the same copy.Compatibility notes
@electron/remote@2.1.3declareselectron >= 13.0.0as its peer range.clearStorageDataquotas,createFromNamedImage) don't affect the APIs these examples use.postinstall; it downloads the first time you run it (npm start→electron .), or on demand with the newinstall-electroncommand. I confirmed the 42.11.18 binary downloads correctly.Verification
In both examples:
npm cipasses.npm ls electron --allshows onlyelectron@42.11.18.npm run build --if-presentandnpm test --if-presentexit 0. Neither example has a build or test script, so both do nothing.npm auditshows 0 high/critical findings. Five moderate findings in@electron/packagerand itsminimatch/globdependencies were there before this change; npm's only fix is a breaking downgrade of@electron/packager.npm audit signaturespasses. 42.11.18 was published 2026-10-21 byelectron-nightly, the same publisher as the previous 41.10.7.At the root,
biome ci .andcheck-biome-versionpass.Not verified
libglib-2.0.so.0, which isn't installed (same failure before the change). Neither example is in the Playwright e2e suite, so please smoke-testnpm startin both before merging.File.path, which Electron removed in v32. It was already broken on 41 and isn't caused by this upgrade.🤖 Generated with Claude Code