Skip to content

Upgrade Electron to 42.x in Electron examples (CVE-2026-115570) - #118

Merged
miguelcalderon merged 1 commit into
mainfrom
support-agent/linear-237d9b21-5afc-4b3a-956c-48918201c91a-97453cea-43f2-4267-98ed-f37ec2d3217a
Nov 16, 2026
Merged

miguelcalderon merged 1 commit into
mainfrom
support-agent/linear-237d9b21-5afc-4b3a-956c-48918201c91a-97453cea-43f2-4267-98ed-f37ec2d3217a

Conversation

@robocop-the-helper

Copy link
Copy Markdown
Contributor

Summary

Raises the electron devDependency from ^41.2.0 to ^42.11.16 in examples/electron and examples/electron-nodeintegration. Both lockfiles now resolve electron@42.11.18.

Electron before 42.11.16 does not block the compromised eMudhra intermediate certificates in Chromium networking or in Node's tls/https/fetch. An attacker holding such a certificate and able to intercept traffic could impersonate a TLS server (GHSA-jr5w-w6x2-84p9, CVE-2026-115570, high). The upgrade also clears the other high-severity Electron advisories npm audit reported against 41.10.7.

Resolves SECSLOP-9 (Dependabot alerts 1780 and 1788).

Changes

  • examples/electron/package.json, examples/electron-nodeintegration/package.json: electron ^41.2.0 → ^42.11.16
  • Both package-lock.json files: only the electron entry changed (41.10.7 → 42.11.18). @electron/remote in the nodeintegration example shares the same copy.

Compatibility notes

  • @electron/remote@2.1.3 declares electron >= 13.0.0 as its peer range.
  • Electron 42's breaking changes (macOS notifications, offscreen scale factor, clearStorageData quotas, createFromNamedImage) don't affect the APIs these examples use.
  • Electron 42 no longer downloads its binary in postinstall; it downloads the first time you run it (npm start → electron .), or on demand with the new install-electron command. I confirmed the 42.11.18 binary downloads correctly.

Verification

In both examples:

  • npm ci passes.
  • npm ls electron --all shows only electron@42.11.18.
  • npm run build --if-present and npm test --if-present exit 0. Neither example has a build or test script, so both do nothing.
  • npm audit shows 0 high/critical findings. Five moderate findings in @electron/packager and its minimatch/glob dependencies were there before this change; npm's only fix is a breaking downgrade of @electron/packager.
  • npm audit signatures passes. 42.11.18 was published 2026-10-21 by electron-nightly, the same publisher as the previous 41.10.7.

At the root, biome ci . and check-biome-version pass.

Not verified

  • I couldn't launch the apps in the sandbox because the Electron binary needs libglib-2.0.so.0, which isn't installed (same failure before the change). Neither example is in the Playwright e2e suite, so please smoke-test npm start in both before merging.
  • Both examples' drag-and-drop code reads File.path, which Electron removed in v32. It was already broken on 41 and isn't caused by this upgrade.

🤖 Generated with Claude Code

Raise the electron devDependency from ^41.2.0 to ^42.11.16 in the
electron and electron-nodeintegration examples. Electron before
42.11.16 does not block the compromised eMudhra intermediate
certificates in Chromium networking or Node tls/https/fetch
(GHSA-jr5w-w6x2-84p9). The lockfiles now resolve electron 42.11.18,
which also clears the other high-severity Electron advisories npm
audit reported against 41.10.7.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@robocop-the-helper
robocop-the-helper Bot requested a review from a team as a code owner November 11, 2026 18:45

@miguelcalderon miguelcalderon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The change is limited to the Electron version, and the lockfiles only swap the Electron entry.

I ran the smoke test the description asked for on macOS: npm ci and npm start in both examples on Electron 42.11.18. Both apps opened and loaded the viewer with no errors. The console warnings I saw (missing baseUrl, the Content Security Policy notice) aren't caused by this upgrade. On the first npm start, Electron now prints "Downloading Electron binary..." and takes a little longer, which is expected.

Not part of this PR: drag-and-drop in both examples still reads File.path, which Electron removed a while ago. It would be good to fix that separately.

@miguelcalderon
miguelcalderon merged commit 4d5e001 into main Nov 16, 2026
3 checks passed
@miguelcalderon
miguelcalderon deleted the support-agent/linear-237d9b21-5afc-4b3a-956c-48918201c91a-97453cea-43f2-4267-98ed-f37ec2d3217a branch November 16, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant