Repository navigation
fix(laravel): require patched symfony/http-foundation and add a Composer cooldown #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[High] Update composer.lock before merging
The committed
composer.lockstill selectssymfony/http-foundationv7.3.7, which does not satisfy the new^7.4.23requirement. Composer rejects this mismatch, so the README'scomposer installstep fails on a clean checkout, and the patched dependency is not delivered.ELI5: The two dependency lists disagree, so new users cannot install the example.
Fix: Regenerate and commit
composer.lockusing Composer 2.11+ with the seven-day cooldown enabled before merging. Then verify a cleancomposer install, runcomposer audit --locked, and smoke-test the viewer.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a76591b. I went with a full
composer updateinstead of justsymfony/http-foundation, because the targeted update still left 12 advisories inlaravel/framework,league/flysystemand other Symfony packages.composer audit --lockedis clean now, and the README steps on a clean checkout load the viewer without errors.