Repository navigation
fix(electron): update examples to patched supported Electron - #115
Open
MahmoudElsayad wants to merge 3 commits into
Open
MahmoudElsayad wants to merge 3 commits into
MahmoudElsayad wants to merge 3 commits into
Conversation
…in-release-age npm 11.21.1 is newer than the npm that Node 24 LTS bundles (11.19.1), so the Playwright workflow failed with EBADENGINE while installing the Electron examples. npm 11.10.0 is the first release that withholds versions younger than min-release-age, so the cooldown still holds wherever the install succeeds.
MahmoudElsayad
marked this pull request as ready for review
November 9, 2026 14:44
miguelcalderon
left a comment
Contributor
There was a problem hiding this comment.
Thanks, the Electron bump looks good and the testing notes are really helpful. One request: please drop the npm 11.10 requirement. The lockfile already pins the patched Electron for any npm version, and the requirement breaks the automated SDK bump, which runs on Node 22 with npm 10. Details inline.
The lockfiles already pin Electron 43.8.4 for any npm version, and the npm requirement broke the SDK bump workflow, which runs npm 10.9.3. Also note that Electron downloads its binary on the first npm start.
MahmoudElsayad
force-pushed
the
security/nov6-electron-certificates
branch
from
November 11, 2026 13:38
1805176 to
5a6574e
Compare
miguelcalderon
approved these changes
Nov 12, 2026
miguelcalderon
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fixes. The npm requirement is gone and the READMEs read well, so LGTM 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Both Electron examples lock Electron 41.10.7, which is affected by GHSA-jr5w-w6x2-84p9 (CVE-2026-115570). Dependabot reports it as https://github.com/PSPDFKit/nutrient-web-examples/security/dependabot/1788 and https://github.com/PSPDFKit/nutrient-web-examples/security/dependabot/1780. This PR updates both examples to 43.8.4, which blocks the compromised eMudhra certificates. Electron 43 is the oldest supported major, because Electron 42 reached end of life on October 20: https://releases.electronjs.org/schedule.
What changed
Both manifests require
^43.8.4, and both lockfiles resolve 43.8.4. npm published this version on October 27, more than seven days before this change. No transitive dependency entries change, and the PR adds no overrides.Each example adds an
.npmrcwithmin-release-age=7andengine-strict=true, and itsenginesfield requires Node 22.12.0 or later. Theenginesfield does not require an npm version, because the lockfile pins Electron 43.8.4 for any npm version, and an npm requirement broke the SDK bump workflow, which runs Node 22.20.0 with npm 10.9.3. So the 7-day cooldown only takes effect with npm 11.10.0 or later, the first release that enforcesmin-release-age, and npm 10 ignores the setting without a warning. The READMEs say this, and they also say that Electron 43 downloads its binary on the firstnpm startinstead of duringnpm install.How I tested it
./tests/pnpm-workflows.test.shandgit diff --checkpass.npm installwith npm 11.19.1 and with npm 10.9.3 installs Electron 43.8.4 and Viewer 1.25.0 in both examples, and neither changes the lockfile.mainwith Electron 41.10.7 for comparison.Existing issues outside this PR
Two failures happen in the same way on
mainwith Electron 41.10.7, so this PR does not cause them. They need a separate fix.instance.exportPDF is not a function. The toolbar sends the viewer instance to the preload script throughcontextBridge, which does not keep prototype methods.File not in PDF format or corrupted.for a PDF picked by its absolute path, including the bundled sample PDF.I did not test packaging with
@electron/packager, the native dialog defaults that changed in Electron 43 (https://www.electronjs.org/docs/latest/breaking-changes), or Windows and Linux. The shared browser suite excludes both Electron examples, so CI does not cover the app itself.