[Config] Add the missing dense-path keys to the heterogeneous config#304
Open
YWHyuk wants to merge 1 commit into
Open
[Config] Add the missing dense-path keys to the heterogeneous config#304YWHyuk wants to merge 1 commit into
YWHyuk wants to merge 1 commit into
Conversation
heterogeneous_c2_simple_noc.yml lacked pytorchsim_functional_mode, pytorchsim_timing_mode and core_spad_size_kb. These keys became mandatory for the dense (ws_mesh) path after the config was last touched, so the heterogeneous run in scripts/stonne_experiment/run.sh died with KeyError: 'pytorchsim_functional_mode' raised from extension_config.__getattr__ as soon as the dense matmul kernel was launched on the second partition. The sparse-only and dense-only modes were unaffected because they use other config files. Values match the systolic_ws_128x128_c1_simple_noc_tpuv3_half config; core_spad_size_kb is 16384, consistent with the 128 lanes x 128 KB per lane already declared here. With this, test_hetro.py --mode 2 completes in 48177 cycles. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3QZ8xomsrbs4SoA5wLQvJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/stonne_experiment/run.shruns three STONNE experiments. The third one --the heterogeneous run (
test_hetro.py --mode 2, sparse core + dense core on twopartitions) -- currently dies as soon as the dense matmul kernel is launched:
configs/heterogeneous_c2_simple_noc.ymlis missing three keys that the dense(
ws_mesh) path requires:pytorchsim_functional_mode,pytorchsim_timing_modeand
core_spad_size_kb. This is config bit-rot -- the file was last touched by aDRAM-config change and never picked up keys that later became mandatory. The
sparse-only (
--mode 0) and dense-only (--mode 1) experiments were unaffectedbecause they use different config files.
Fix
Add the three keys. Values match
systolic_ws_128x128_c1_simple_noc_tpuv3_half.yml, the config the dense-onlyexperiment already uses.
core_spad_size_kb: 16384is consistent with the128 lanes x 128 KB per lane this file already declares.
Verification
On
develop(e671371), all three experiments fromrun.shat M=N=K=1024,sparsity 0.9:
The standalone sparse path (
tests/system/test_stonne.py) was also checked andscales with sparsity as expected -- at size 32: 50990 / 28022 / 8488 cycles at
sparsity 0.0 / 0.4 / 0.8.
Note (not fixed here)
scripts/stonne_experiment/run_trace.shgreps forStonne Core [0] : Total cyclebut the simulator now prints
StonneCore [0] : Total cycle(no space), so thatscript silently reports empty cycle counts. It also hardcodes
/workspace/PyTorchSimand runs the same script twice while labelling one row "TOG". Left alone since the
original intent is unclear.
🤖 Generated with Claude Code
https://claude.ai/code/session_01D3QZ8xomsrbs4SoA5wLQvJ