Skip to content

🎉 feat(viewer): add iso-contour option - #514

Merged
casenave merged 2 commits into
mainfrom
feat/viewer-color-levels
Oct 21, 2026
Merged

casenave merged 2 commits into
mainfrom
feat/viewer-color-levels

Conversation

@jeanfreddiebold-png

Copy link
Copy Markdown
Contributor

Thanks for contributing! Please make sure your PR title and content follow the guidelines.
Leave this checklist below in your PR description and tick the corresponding boxes.

Checklist

  • Typing enforced
  • Documentation updated
  • Changelog updated
  • Tests and Example updates
  • Coverage should be 100%

✅ PR Title Format

Your PR title must start with one of the following emojis to indicate the type of change:

  • 🐛 Bug fix
  • 📄 Documentation
  • 🎉 New feature or initial commit
  • 🚀 Performance or deployment
  • ♻️ Refactor or cleanup
  • 📦 Packaging or dependency management (e.g., pyproject.toml, conda, Poetry, pre-commit)

Example:
🎉 Add MMD-based split method


📋 Description (optional)

Please explain what your PR does:

  • What problem does it solve?
    when plotting fields, stress engineer usually look at iso contour which higlights gradients and critical areas. All current tools use this viewing setting by default (Ansys WB for mechanical and fluent, Patran, Mentat...). Without it, the plot doesn't look professionnal.
    For obtaining clean iso contours, this interpolation parameter is changed :
    self.mapper.SetInterpolateScalarsBeforeMapping(bool(iso_contour))
    it may be usefull to check that, on big meshes, it doesn't deteriorate the rendering speed

  • Any breaking changes?
    no

  • How was it tested?
    verification that the status is impacted, and that the variable are affected by changes


🔗 Related issues (optional)

Closes #___

@jeanfreddiebold-png
jeanfreddiebold-png requested a review from a team as a code owner October 20, 2026 14:40
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jean-Frederic Diebold seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jeanfreddiebold-png

Copy link
Copy Markdown
Contributor Author

@fbordeu @fabiencasenave je vous propose cette option pour faire des iso contours dans les résultats de calcul. Je crois que le code affecté ne touche que le nécessaire, peut être que le bouton pourrait être un peu mieux disposé, et je n'ai pas pu tester si le changement d'interpolation affecte la vitesse d'affichage de gros modèles. Elle n'est activée que pour les iso contours, et est nécessaire pour obtenir des iso régulière qui ne suivent pas le maillage

@casenave casenave changed the title Feat/viewer color levels 🎉 feat(viewer): add iso-contour option Oct 20, 2026
@casenave

Copy link
Copy Markdown
Member

@jeanfreddiebold-png thanks! the number of contours seems to be hard-coded, but I think it's not a big deal to me (we should not recode paraview!)

@casenave casenave left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jeanfreddiebold-png

Copy link
Copy Markdown
Contributor Author

yes i hardcoded the number for keeping the interface light and easy to read. In my experience, once set by the software, this number is very rarely changed by the user.

@fbordeu

fbordeu commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Looks nice to me, We have to be careful not to add to many functionalities to the viewer. The viewer is for qualitative analysis.

  • Split names, number of samples
  • Fields presents (including globals)
  • Some analysis for the globals
  • Simple visualisation of the samples

For more Quantitative analysis there is ParaView. I just created a PR for a button to open the database in ParaView for more extensive quantitative analysis.

#516

@fbordeu

fbordeu commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Nothing to add, ready for merge

@casenave
casenave merged commit 5a837a2 into main Oct 21, 2026
11 of 13 checks passed
@casenave
casenave deleted the feat/viewer-color-levels branch October 21, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants