Repository navigation
🎉 feat(viewer): add iso-contour option - #514
Conversation
|
Jean-Frederic Diebold seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@fbordeu @fabiencasenave je vous propose cette option pour faire des iso contours dans les résultats de calcul. Je crois que le code affecté ne touche que le nécessaire, peut être que le bouton pourrait être un peu mieux disposé, et je n'ai pas pu tester si le changement d'interpolation affecte la vitesse d'affichage de gros modèles. Elle n'est activée que pour les iso contours, et est nécessaire pour obtenir des iso régulière qui ne suivent pas le maillage |
|
@jeanfreddiebold-png thanks! the number of contours seems to be hard-coded, but I think it's not a big deal to me (we should not recode paraview!) |
|
yes i hardcoded the number for keeping the interface light and easy to read. In my experience, once set by the software, this number is very rarely changed by the user. |
|
Looks nice to me, We have to be careful not to add to many functionalities to the viewer. The viewer is for qualitative analysis.
For more Quantitative analysis there is ParaView. I just created a PR for a button to open the database in ParaView for more extensive quantitative analysis. |
|
Nothing to add, ready for merge |
Thanks for contributing! Please make sure your PR title and content follow the guidelines.
Leave this checklist below in your PR description and tick the corresponding boxes.
Checklist
✅ PR Title Format
Your PR title must start with one of the following emojis to indicate the type of change:
Example:
🎉 Add MMD-based split method
📋 Description (optional)
Please explain what your PR does:
What problem does it solve?
when plotting fields, stress engineer usually look at iso contour which higlights gradients and critical areas. All current tools use this viewing setting by default (Ansys WB for mechanical and fluent, Patran, Mentat...). Without it, the plot doesn't look professionnal.
For obtaining clean iso contours, this interpolation parameter is changed :
self.mapper.SetInterpolateScalarsBeforeMapping(bool(iso_contour))
it may be usefull to check that, on big meshes, it doesn't deteriorate the rendering speed
Any breaking changes?
no
How was it tested?
verification that the status is impacted, and that the variable are affected by changes
🔗 Related issues (optional)
Closes #___