Skip to content

Java17 - #8

Open
harsha-amarasiri wants to merge 8 commits into
OxalisCommunity:feature/java-17-upgradefrom
harsha-amarasiri:java17
Open

Java17#8
harsha-amarasiri wants to merge 8 commits into
OxalisCommunity:feature/java-17-upgradefrom
harsha-amarasiri:java17

Conversation

@harsha-amarasiri

Copy link
Copy Markdown

Pull Request Description

Java 17 upgrade and dependency and plugin upgrades with BouncyCastle 1.85 test compatibility fix

Java 17 upgrade
update compile targets and CI/CD to Java 17

Dependency updates:

  • org.bouncycastle:bcpkix-jdk18on 1.84 → 1.85
  • com.google.guava:guava 33.6.0-jre → 33.7.1-jre
  • com.sun.xml.bind:jaxb-impl 4.0.6 → 4.0.9
  • jakarta.xml.bind:jakarta.xml.bind-api 4.0.5 → 4.1.0-M1
  • joda-time:joda-time 2.14.2 → 2.14.3
  • network.oxalis.pkix:pkix-ocsp 2.6.1-SNAPSHOT-j17 → 2.6.2

Plugin updates:

  • maven-gpg-plugin 3.0.1 → 3.2.8

Test fix:

  • BouncyCastle 1.85 enforces ISO 3166-1 / X.520 strict validation requiring the C (Country) attribute in X.500 Distinguished Names to be exactly 2 characters
  • X509TestGenerator was using C=None (4 characters) as a placeholder country code in self-signed test certificate generation, causing all tests that rely on dynamically generated certificates to fail with IllegalArgumentException
  • Replaced C=None with C=NO across all three DN string occurrences in X509TestGenerator

Key component affected:

  • X509TestGenerator - test utility for generating X.509 certificates used across ExpirationRuleTest, ExpirationSoonRuleTest, CriticalExtensionRequiredRuleTest, and NorwegianOrganizationNumberRuleTest

Type of Pull Request

  • [ x] New feature/Enhancement - non-breaking change which adds functionality
  • Bug fix
  • Breaking change (Require Major version change?)

Type of Change

  • OpenPeppol eDEC Specifications
  • Peppol AS4 Profile specification
  • Peppol Business Envelope specification
  • Peppol Policies specification
  • Peppol eDEC Code Lists specification
  • OpenPeppol Spring/Fall release
  • Oxalis software internal change or enhancement
  • General change

Pull Request Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas. But did not add unnecessary annotation/comment say @author name etc
  • I have checked my code for variable and method name and corrected grammar/spelling mistakes if any
  • I have made corresponding changes to the documentation where needed
  • My changes generate no new/additional warnings
  • My change is not breaking or creating conflict with associated dependencies
  • I have performed a self-review of my own code
  • I ran mvn clean install before commit and all tests run successfully
  • I conducted basic QA to assure all features are working fine
  • My pull request generate no conflicts with master branch
  • I requested code review from other team members

aaron-kumar and others added 8 commits August 16, 2026 19:05
…e 1.85 test compatibility

Dependency updates:
- org.bouncycastle:bcpkix-jdk18on 1.84 -> 1.85
- com.google.guava:guava 33.6.0-jre -> 33.7.1-jre
- com.sun.xml.bind:jaxb-impl 4.0.6 -> 4.0.9
- jakarta.xml.bind:jakarta.xml.bind-api 4.0.5 -> 4.1.0-M1
- joda-time:joda-time 2.14.2 -> 2.14.3
- network.oxalis.pkix:pkix-ocsp 2.6.1-SNAPSHOT-j17 -> 2.6.2

Plugin updates:
- maven-gpg-plugin 3.0.1 -> 3.2.8

Fix: BouncyCastle 1.85 enforces ISO 3166-1 / X.520 requiring country codes
to be exactly 2 characters. Replaced invalid C=None (4 chars) with C=NO
in X509TestGenerator to restore test compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants