[ENHANCEMENT] Add shelter class to the buildings schema - #656
Merged
Seth Fitzsimmons (sethfitz) merged 2 commits intoAug 13, 2026
Merged
Conversation
Adds 'shelter' to the building class enum so structures like public transport shelters (OSM amenity=shelter + building=*) can receive a class value instead of null. Fixes #326 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alex Iannicelli <atiannicelli@gmail.com>
Copilot started reviewing on behalf of
Alex Iannicelli (atiannicelli)
August 12, 2026 20:04
View session
Alex Iannicelli (atiannicelli)
temporarily deployed
to
staging
August 12, 2026 20:05 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the buildings/building schema to classify shelter structures by adding a shelter option to the class enum, enabling OSM-derived shelter buildings to be assigned a non-null class value.
Changes:
- Added
shelterto theclassenum in the building YAML schema (kept alphabetically sorted). - Added
SHELTER = "shelter"to the PythonBuildingClassenum. - Updated the baseline JSON-schema test fixture to include
"shelter"in the enum list.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| schema/buildings/building.yaml | Adds shelter to the class enum in the canonical schema. |
| packages/overture-schema-theme-buildings/src/overture/schema/buildings/building.py | Adds the matching Python enum constant for BuildingClass. |
| packages/overture-schema-theme-buildings/tests/building_baseline_schema.json | Updates the baseline enum list to keep schema tests in sync. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
Alex Iannicelli (atiannicelli)
added
the
change type - minor 🤏
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alex Iannicelli <atiannicelli@gmail.com>
Victor Schappert (vcschapp)
approved these changes
Aug 13, 2026
Seth Fitzsimmons (sethfitz)
approved these changes
Aug 13, 2026
Seth Fitzsimmons (sethfitz)
deleted the
atiannicelli-add-shelter-building-class
branch
August 13, 2026 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
sheltervalue to theclassenum ofbuildings/buildingso that shelter structures — e.g. public transport (bus stop) shelters mapped in OSM asamenity=shelter+building=*— can receive aclassinstead of being left null.Fixes #326
Changes
schema/buildings/building.yaml: addshelterto theclassenum (alphabetical order)packages/overture-schema-theme-buildings/src/overture/schema/buildings/building.py: addSHELTER = "shelter"toBuildingClasspackages/overture-schema-theme-buildings/tests/building_baseline_schema.json: add"shelter"to the baseline enumNon-breaking enum addition; no migration needed.
Note: a follow-up change in the data pipeline is required to actually map OSM
amenity=shelter/building=shelterfeatures toclass=shelter.Testing
pytest packages/overture-schema-theme-buildings/— baseline JSON-schema tests pass (2 passed)schema/buildings/building.yamlparses and theclassenum remains alphabetically sorted