[BUG] Correct broken guide links in theme definitions table - #483
Merged
Adam Lastowka (Rachmanin0xFF) merged 2 commits intoAug 13, 2026
Conversation
Theme guide links used relative paths like ./addresses, resolving to dead links (e.g. /addresses) instead of the actual guide URLs under /guides/. Fixed all six theme guide links (Addresses, Base, Buildings, Divisions, Places, Transportation). Signed-off-by: Adam Lastowka <adamlastowka@gmail.com>
Copilot started reviewing on behalf of
Adam Lastowka (Rachmanin0xFF)
August 13, 2026 19:48
View session
Alex Iannicelli (atiannicelli)
approved these changes
Aug 13, 2026
Alex Iannicelli (atiannicelli)
left a comment
Alex Iannicelli (atiannicelli)
left a comment
Contributor
There was a problem hiding this comment.
oops
Adam Lastowka (Rachmanin0xFF)
temporarily deployed
to
staging
August 13, 2026 19:49 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
🗺️ OMF Docs previews are live!
Auto-gen schema site is now available. This is an early preview of a future workflow where we will automatically generate and publish reference docs for the Overture Maps Format schema. The auto-gen schema site may contain incomplete or inaccurate information as we are still refining the generation process, so please compare against the repo schema site and refer to the official Overture documentation for authoritative information. Note ♻️ This preview updates automatically with each push to this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the theme definitions table’s in-page data so each theme’s “Open the … guide” link points at the correct guide location under /guides/, addressing broken navigation reported in #482.
Changes:
- Updated 6 theme
guidelink values (Addresses, Base, Buildings, Divisions, Places, Transportation) to point to guide pages under/guides/.
Suppressed comments (5)
static/theme-definitions-table.html:240
- These guide URLs are absolute (start with
/), which bypasses DocusaurusbaseUrl(configurable viaDOCUSAURUS_BASE_URL). If the site is served under a non-root baseUrl (e.g./docs/), this link will incorrectly resolve to/guides/...instead of<baseUrl>/guides/.... Prefer a relative./guides/.../path like the existing “Back to Guides” link.
"guide": "/guides/base/",
static/theme-definitions-table.html:336
- These guide URLs are absolute (start with
/), which bypasses DocusaurusbaseUrl(configurable viaDOCUSAURUS_BASE_URL). If the site is served under a non-root baseUrl (e.g./docs/), this link will incorrectly resolve to/guides/...instead of<baseUrl>/guides/.... Prefer a relative./guides/.../path like the existing “Back to Guides” link.
"guide": "/guides/buildings/",
static/theme-definitions-table.html:476
- These guide URLs are absolute (start with
/), which bypasses DocusaurusbaseUrl(configurable viaDOCUSAURUS_BASE_URL). If the site is served under a non-root baseUrl (e.g./docs/), this link will incorrectly resolve to/guides/...instead of<baseUrl>/guides/.... Prefer a relative./guides/.../path like the existing “Back to Guides” link.
"guide": "/guides/divisions/",
static/theme-definitions-table.html:568
- These guide URLs are absolute (start with
/), which bypasses DocusaurusbaseUrl(configurable viaDOCUSAURUS_BASE_URL). If the site is served under a non-root baseUrl (e.g./docs/), this link will incorrectly resolve to/guides/...instead of<baseUrl>/guides/.... Prefer a relative./guides/.../path like the existing “Back to Guides” link.
"guide": "/guides/places/",
static/theme-definitions-table.html:696
- These guide URLs are absolute (start with
/), which bypasses DocusaurusbaseUrl(configurable viaDOCUSAURUS_BASE_URL). If the site is served under a non-root baseUrl (e.g./docs/), this link will incorrectly resolve to/guides/...instead of<baseUrl>/guides/.... Prefer a relative./guides/.../path like the existing “Back to Guides” link.
"guide": "/guides/transportation/",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Absolute paths (/guides/...) bypass the Docusaurus baseUrl and break under a non-root DOCUSAURUS_BASE_URL. Switch to relative paths (./guides/...) consistent with the existing back-link. Signed-off-by: Adam Lastowka <adamlastowka@gmail.com>
Adam Lastowka (Rachmanin0xFF)
deleted the
482-bug-guide-links-in-the-theme-definitions-table-are-broken
branch
August 13, 2026 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #482
Theme guide links used relative paths like ./addresses, resolving to dead links (e.g. /addresses) instead of the actual guide URLs under /guides/. Fixed all six theme guide links (Addresses, Base, Buildings, Divisions, Places, Transportation).