Repository navigation
fix epoch rounding bug & startup issue - #303
Merged
Merged
Conversation
NeerajGodiyal
left a comment
NeerajGodiyal
left a comment
Collaborator
There was a problem hiding this comment.
Found one pre-VAT reward regression in the historical commission fallback; details inline.
7layermagik
previously approved these changes
Oct 13, 2026
NeerajGodiyal
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found two divergences, as below:
preserve historical vote commissions across startup and restarts so epoch rewards are distributed correctly
match Agave’s inflation rounding to prevent occasional one-lamport differences at epoch boundaries
restore the parent blockhash after loading a snapshot so durable nonce transactions execute correctly in the first block we replay
These are fixed in this PR.