Repository navigation
Add rooted block history RPC methods - #284
Open
NeerajGodiyal wants to merge 9 commits into
Open
NeerajGodiyal wants to merge 9 commits into
NeerajGodiyal wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
getBlock,minimumLedgerSlotandgetFirstAvailableBlockfor retainedrecent blocks. Record block metadata and fee rewards during Alpenglow replay.
getBlockrequirestransactionDetails: "none"for summary requests. Rewardsare included by default;
rewards: falseomits them. Slots and options arevalidated without floating-point rounding.
The methods read retained rooted history.
confirmedandfinalizedareaccepted. This PR does not retain transaction payloads, so full, signatures and
accounts detail modes return an error. The default detail mode is full.
Related work
Full transaction responses and
getTransactionbelong to the separatetransaction-history work. These summary methods do not depend on it.
Complete exporter integration also needs #280 for epoch length, #282 for node
information and #283 for validator metrics. Inflation rewards from #285 are
already merged.
Testing
The candidate on
348704c4passed native race tests for replay, execution,RPC/account/reward behavior and block history, followed by repository-wide vet,
build and CLI compilation. All 1,122 parent test executions passed without Go
skip events. The optional external program workloads were not enabled because
their pinned arithmetic fixture was unavailable.
HTTP tests cover exact slot values, null options, invalid types, reward
inclusion/omission, empty rewards, nullable commission and unsupported detail
modes. Recovery tests cover fork changes and restart.
The upstream integration adjusts one test to check the snapshot-initialized
parent hash. It does not change that hash or undo upstream nonce handling.
Earlier exporter checks used a combined Mithril build; they do not establish
public-cluster results for this follow-up.