fix(ai): settle the stream status when a request ends without a terminal callback - #2965
Merged
Merged
Conversation
…nal callback An SSE stream could end after a business error payload without onSuccess, onError or onStop, so the hook stayed in LOADING and the assistant bubble kept spinning next to the error that had already arrived. - track whether a terminal callback fired and fall back to ERROR in the finally block, only while the request is still the current generation on a mounted component - stop the active request when the chunk handler surfaces an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SSE stream could end after a business error payload without
onSuccess,onErrororonStop, souseSSERequeststayed inLOADINGand the assistant bubble kept spinning next to the error that had already arrived.ERRORin thefinallyblock, only while the request is still the current generation on a mounted componentReproduced with a Gateway business error (
LOCAL_AI_USAGE_LIMIT): before the change the bubble showed the error and the model logo kept spinning; after the change the generation ends and the send button returns to its idle state.