Skip to content

Remove Supernova strategy from the OETH Vault#2890

Open
naddison36 wants to merge 3 commits into
masterfrom
nicka/remove-supernova
Open

Remove Supernova strategy from the OETH Vault#2890
naddison36 wants to merge 3 commits into
masterfrom
nicka/remove-supernova

Conversation

@naddison36
Copy link
Copy Markdown
Collaborator

@naddison36 naddison36 commented May 7, 2026

Governance

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.29%. Comparing base (800ef7a) to head (69e9e8b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2890      +/-   ##
==========================================
- Coverage   41.39%   41.29%   -0.10%     
==========================================
  Files         115      114       -1     
  Lines        4948     4947       -1     
  Branches     1372     1372              
==========================================
- Hits         2048     2043       -5     
- Misses       2897     2901       +4     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

clement-ux
clement-ux previously approved these changes May 8, 2026
Copy link
Copy Markdown
Collaborator

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sparrowDom
sparrowDom previously approved these changes May 8, 2026
Copy link
Copy Markdown
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naddison36 naddison36 dismissed stale reviews from sparrowDom and clement-ux via 69e9e8b May 11, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants